Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wVLVA-001teU-15 for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Jun 2026 03:45:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wVLV8-009sg5-2t for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Jun 2026 03:45:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wVLV8-009sfu-1x for pgsql-hackers@lists.postgresql.org; Fri, 05 Jun 2026 03:45:42 +0000 Received: from fhigh-b2-smtp.messagingengine.com ([202.12.124.153]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wVLV6-00000001Lxd-1GIq for pgsql-hackers@lists.postgresql.org; Fri, 05 Jun 2026 03:45:42 +0000 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.stl.internal (Postfix) with ESMTP id 7E2E17A0137; Thu, 4 Jun 2026 23:45:38 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Thu, 04 Jun 2026 23:45:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1780631138; x=1780717538; bh=llnSl5zBUd Ht2Sh25x3CE0sOCCBQDHk5hH1Ikc+hzjg=; b=pCD/lldzxqV3/E8d5HZgkFOaZ9 8cTCvn6TrT9UZjhtVYLjbU95OEeTTMmd/W++Ch2/T7z+SNJkjdEur4O5aCZz6waY 57+3wdzHx1sIWk2bLWDa1WcCcylpqgDxulajjuaHeUR4rH62B6N/Aj18z6+wLVaI W9jdqTE1gKuyqzKbdriFbEFIGJ0uUvTWjbhyr6sv4TA23OBdmDxJ1HVsVaUoNAP9 2+JpbFXciRqh0GCK3lahTA01bHdGKBcT7LgAYSXa/RIa7dBkbG9oTPBMa8pLW7Gx sfOUFf+glm4VgSvzFrSwDUu65yQO0jJzi8kPEQABl5waJgPp8nQt+YZFQkLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1780631138; x=1780717538; bh=llnSl5zBUdHt2Sh25x3CE0sOCCBQDHk5hH1 Ikc+hzjg=; b=BQ/2ZPv8KfubiE8NaDmfDPjG6bBB64SfY0xzkpD3KRYMr1aNKTI ZlsXa86CvZFoyrWetkvqTNfJs6APPsAQWO5bc2zFlf/laz5xdtbik+1EcdmbjDcW 57+hOgI+G4esR4CycJQrSfyynk75RzpdSFywv7zYcUoZGsXU+BwCJEdd0MJRYPmK g0lNBybVGQqcP4x+Pq/X/9A/rfmLlblmdw16Gu/EQ8TlY26yzOT2UDRmePJMsPme oxBFiRTfALxH9nbV9HtPMtQsFKgQA3co8hFesAppcSHc8DyTBcDXnMCtkzHP4W6R bOeygy+WaINESFFZW1E6NFanZKIaIF4duYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFxRznQFZuwKssts8zyBwA2V+nw4duvkGG7Wew2oNZEcOoEqzIhVeh0a/t8q4ms90 K2/khHIzxkNjy8iSbgGZ0tuFv0k4bJEcYG8FeDvbSOYmvdW80Qusyv7OzqQAPcL37npyUN 9u6pKgAg6q6B8WgTVeXglzwLBO0SN8YrVqWovrmcov73W8oU2uyZHmMPGL2XOfG+jLHt6v 9UYyCcssLNTLf+kOIFC7BJUGSNisWRMl9VM/GArh2QmbY5EiPqcYuZcHC/2cTCHoDHhVI5 Y6eTEA4G7aUFfLm5yiI8PURu2JiMVgafoA152/3qIaFjHb8FGmyJ/MNHdV+Syj5SrkA2VJ d5ctx6c9YjsEHTQDONCSsYKgxnq5V+a9A1CMoRj0ZfcmRZg6bnmarkSPNAz24uFX5Oz9b6 FPiKAiG8Wje+Yzpf/EhcAykvyHcfLINaNsP7ph9Ut332pH7m+HHY/7u/PWwDoPnBfMtCLG ex8/+YTJMCB1nK/Ahq2ReyiCg1vzpt75fg0rauL7xJH83eVXPGLOCGhNVmBO3mVVYNOi9A hyFlTgetAPbwmxR8MPY/WuVmVzd1Q/J7u3XH/efgRvzDZAcw6mMDMf+CaR7afLDfAgIbib uQA0NxeLrINt7YJgmyZHbFnKItRME2SYJa53Ihg9yUcCQZbG29UC4Es6LYxg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Jun 2026 23:45:36 -0400 (EDT) Date: Fri, 5 Jun 2026 12:45:32 +0900 From: Michael Paquier To: Baji Shaik Cc: pgsql-hackers@lists.postgresql.org, john.naylor@postgresql.org Subject: Re: [PATCH] Use ssup_datum_*_cmp for int2, oid, and oid8 sort support Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EljNyXpZFxMm+qj1" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --EljNyXpZFxMm+qj1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 03, 2026 at 06:37:09PM -0500, Baji Shaik wrote: > int2 uses ssup_datum_int32_cmp because there is no int16-specific > helper, every int16 fits losslessly in int32, and int32_cmp is more > efficient than signed_cmp (4-byte radix passes instead of 8). That's nice for such a simple change. That seems correct to me. Could you add that to the next commit fest please at [1]? > Other custom fastcmp users in core (float4/float8, varlena types) > cannot be trivially switched due to NaN handling or locale-dependent > comparison, so they are left as-is. Nope, we cannot do that. [1]: https://commitfest.postgresql.org/59/ -- Michael --EljNyXpZFxMm+qj1 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmoiRlwACgkQnvQgOdby QH3mAw//RhhWk0YNkJtl/h2+5MUrESgG3iEQv44gQHfKlG1AtyEQLUiLoLx5symq se/2XIrGGXVpzwe5X9XrzWdRamU51lbCIYiKLJGqLbVSEPyZWV38Gk7x80rhZcBu KzeYXPbHRWY7kQAyBGrZVX5wM3nao54gvNbB2CAZMaP46ruFWaFC3+4uJOEBqz4+ kQj4c5cDhSL+enZ7zmND+8dPxAeyoOezcgk4o+apckPjAfqRh7QGyjhN0n85FeWc L/alzAboDgiuDptRVElxW6lU42BImVEu+Yqo3DR6NyuVuqfk7F/XUt82LtQqCjlZ 4Wz/H4yde2O8TaAeXjO05UxoOdZ2Ri1kEfuV72EQXzyylelvJUtYBHWPWwzPiwPK IjbXaK3f+z8Ei1Dt4MEsdqYPSxA2NnCWiOBOSByOLwLXnXXvnfS5/6GNAZ46CNKR GaMiFkDjwvnJ4X+xeq7jlOlACwnrjwifB0ApVr3b9PXf2zv4HigWrAkaDbQYTnSH TOBsn2Rtg3ZrkEdd6hixCVPfl4ZZoWnIFqz/nO+suYdtaq0DF01ZyPXmlhHtTwZa /gVn2FCftn6wjVbR43hf1DfHJxYKqwDKT7SQTVZdatY7GxsomZh4Md1QgPQO3hY0 i+48LD5WbZQyfOvMReduaNGD3OsGMsYwho8iOgt2mMJAW3P7XRo= =GZUa -----END PGP SIGNATURE----- --EljNyXpZFxMm+qj1--