Feedback-ID: ie3de48e3:Fastmail
Date: Sun, 7 Jun 2026 17:44:54 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: JoongHyuk Shin <sjh910805@gmail.com>
Cc: Scott Ray <scott@scottray.io>, Fujii Masao <masao.fujii@gmail.com>,
	Michael Paquier <michael@paquier.xyz>, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC
 assign hooks
Message-ID: <aiWRWxs3Y0veciBY@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACSdjfNr8cm1-GPBv8Sqa7N9Uhi9-gR4wHzbTpm9rmW2D=4ftg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aiWRWxs3Y0veciBY%40alvherre.pgsql>
Precedence: bulk

On 2026-Jun-07, JoongHyuk Shin wrote:

> On "=" vs "set to": I'd stay with "=".
> The list is assembled in appendStringInfo and ends up in the dynamic %s,
> so prose like "set to" there never goes through gettext
> and would print in English even under a translated lc_messages.
> "=" is punctuation, so it sidesteps that.

Agreed on using =, although ...

> That said, I'm not sure the currently-set list belongs in the errdetail at
> all,
> since an operator can read the values back from the configuration.
> I'd be interested in the committer's view on whether it is worth adding.

It may be enough to list which ones are set, without listing their values.
Those can be obtained easily from pg_settings, which can be mentioned in
errhint -- useful also to figure out exactly _where_ they are set (e.g.,
in an include file, postgresql.auto.conf, and so on.)

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/