Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 8 Jun 2026 12:44:05 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Baji Shaik <baji.pgdev@gmail.com>, Tristan Partin <tristan@partin.io>,
	bertranddrouvot.pg@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Fix memory leak in pgstat_progress_parallel_incr_param()
Message-ID: <aiY6hfUWWU0Qi24t@paquier.xyz>
References: 
 <CA+fm-RMopta1Dmq8udiU5sp+zwTvhUf4+xfbr3rZDfczH+p-xw@mail.gmail.com>
 <DJ1FOVN3MWNT.1ZQ7NHQAVJPXY@partin.io>
 <CA+fm-RMwUuX7SimgfHZ1o3=RYWQT7wC+KC2+uAgbPqHij25mug@mail.gmail.com>
 <CAA5RZ0sb06bJecz1=0GtM69hO9HarCD_1+m0YOmyZ_PpEs_M6Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ZWknU4PJB7atdWfx"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0sb06bJecz1=0GtM69hO9HarCD_1+m0YOmyZ_PpEs_M6Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aiY6hfUWWU0Qi24t%40paquier.xyz>
Precedence: bulk


--ZWknU4PJB7atdWfx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 06, 2026 at 09:55:05AM -0500, Sami Imseih wrote:
> Hi,
>=20
> good find, and thanks for the patches!
>=20
> >   0001: drop the redundant initStringInfo() call (backport candidate)
>=20
> This one looks like an obvious fix to me.

And clearly something that should be backpatched down to v17, or we
could pile a lot of memory depending on how many calls we do in a
worker, with more piling over time.

Will process, thanks!

>>   0002: allocate the static buffer once per process via
>>         pq_beginmessage_reuse / pq_endmessage_reuse, to avoid the
>>         per-call allocation (master only)
>=20
> I am less convinced this will have any benefits for the additional comple=
xity.
> The callers of pgstat_progress_parallel_incr_param() are not frequent eno=
ugh
> to make a measurable difference here. cost delay reporting for parallel w=
orkers
> is throttled by PARALLEL_VACUUM_DELAY_REPORT_INTERVAL_NS and
> index progress reporting does not happen very frequently either.

I doubt that 0002 is worth doing, particularly seeing the code paths
where this is called.
--
Michael

--ZWknU4PJB7atdWfx
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmomOoUACgkQnvQgOdby
QH3UkA//exUgxjvAeQPYu1cUSua71WWLL3Rda0QrlLcFL3Ru+fKhLlUybDrdK0iW
F0PcBUR6A7p8ylq6OfznSjAvz2FOvcEylOUa63cif20XYE+2Mm6iXPvNl614DaIn
fHrZL4dnxfJMLx7jgFuL4WI98lphaugQl2Y/BNmz8rrBMkJ6lplbIc4r5j+3k6z6
htYaRhlg5C+YSc4RqhC7Rp6I3eZ9SN5NB6qIsG4rYVBuxW7hu3bDulkqCPjq83No
Xp07s8eLLB5a05sKNpP3ckN8u6y8VrnOyLBdj6BOGA8lAXd1dQkEoWoabWH2l4iZ
gKYNb2XxgRwZgQ4JPduoyLfYyQ6sPcd5tV30G0YWO3b02ao3+AbjcSw61GBGRtkx
uCvIQXKkI8gOvCtWzyQpCFFIoyruhdzSqhsbWeYleHp0VdRUbaSlOqK6Xf+DTD9w
oQTo7KpMg8LeJpvS+iN5aYyrHZ5kSfCA8eZiWAyX/Zs169Kjb1Z0hjh+Al5OBt/1
ql7UdKJBuRYSN0Ew/9TyLyBESOZpI1GMPZzIvrLG124usCPWn3VUXq+eiBYJDJ7D
uZjCqkp1zoFVAiBNfZ6cMjsqkR2B75m/AR0KXRwA2bfb4uEK+o8fYLXC44md8IR1
ku5NgJlOXa6vcdLcQpLUq5yqu27qwqGm0GzTpJUSw2mluDKyWx4=
=2XTi
-----END PGP SIGNATURE-----

--ZWknU4PJB7atdWfx--