Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wWNMk-002ZMF-2d for pgsql-hackers@arkaria.postgresql.org; Sun, 07 Jun 2026 23:57:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wWNLi-0006Hs-1s for pgsql-hackers@arkaria.postgresql.org; Sun, 07 Jun 2026 23:56:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wWNLh-0006Hi-22 for pgsql-hackers@lists.postgresql.org; Sun, 07 Jun 2026 23:56:14 +0000 Received: from fout-a8-smtp.messagingengine.com ([103.168.172.151]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wWNLf-00000001bVL-2vUs for pgsql-hackers@lists.postgresql.org; Sun, 07 Jun 2026 23:56:12 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id 400D8EC0179; Sun, 7 Jun 2026 19:56:10 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Sun, 07 Jun 2026 19:56:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1780876570; x=1780962970; bh=nDNoocPLb6 bG+bJC23CsMIvgqQ+AI4lVcu7pbfpN76c=; b=ocT/EHi0reAORuuNhSq4O6r9va +D3a+f44iMssm3zz1GpZUQrVQ0VNzP4kZ0ptBavSsd9YngEk+deK3vd0eO1Vw7FN UyfPzj1a2LOx9XKSTPO5Buh5PYlNQ2V5xR2Uykf71O9QOYFJ2mti+mETPmv44lXk GUbaOtUKp7BrtfEfJRgKBhGbnAhlYOFYRkm0Z2Y0tUrwMF0Q8euWxUVdIJoI4WDW 7lU9vpyh9aVu2ZE0d5i+nVE+1uKOAo56vL0j8JyqRnBAE1CmWor1YLvbukg9y635 Dk9jG5rhe49sgbH/vL/t7Twx6pl8xcfl8VANH9G3TWVSoxfHFtYEmj2uceGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1780876570; x=1780962970; bh=nDNoocPLb6bG+bJC23CsMIvgqQ+AI4lVcu7 pbfpN76c=; b=H4ZyxfD2iDaL7ATQwvhXWPzPQmv/xJtq/WwDzrsTfd421eVaqrg 2hQq8a/PvxYORj8FZxcwE2aw0wGChX0MjnX3PcflE4ziFaFFjdQXiu+FwSaOpga5 LcJ4dFrKvJkNl2ivfAA2NmK5Wb6CiYwuHvf3SwNRUaLWpBpzHukNFr3CqfN562kz g6XdFAnorLvZ0l3ym3xFJcc8ox6dnWow2sqoRxW/CiCVK6aa8XKKHEbiFvkbRC/O ar1f8WD6kQeVFH/JzbM+eR25HIVA/Su9MmtyNjZ7SealHwQyuyzTj1nMNFqWa8fk OpCtvynkSSwBEdSQsCzx2p6z7UFuJLH8t5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFSFZPff458uORrBO7jkN6EeDdCFaS/KN6974mafz1vitLoQSzUFxMp3bsxYJY9x9 +Luz/+ObySZIZ1mM3xINIc8fG4TXFc+myrKPjIzkfoWxIFvykvNOcqp8WDpujKpEzwGQ0A y9G77DP5v3fTHt6WOKXSnLO5FLKOFz6RPCVg7ddNGXRqGplZb33kX7QminCs7+o0yu0HSG /fK4tTWalGDomdRooJNapAEjUi1A3gsPM2yLim4uGoz0G1tR9wNdyvuf9SCOT1vk7oU9h9 4Oy69+5ZPGGBg7D4kBZIwDyueQjcoCmVJavrvZAo46AhHZv97FxPWtE/6n6JrnuJARLucK bVP2xK9pgRf6gBl84iD6yVgD0iGQ26hYzVq+zsqUZcUvwcKNN1Qt8k5iNnqwqeNa2+29qE JaS13+lfPuzv/1o/C6keXWV5q2p85sIXKNxx+iOKqxSUWcYABv+qtysZdhDfriMVWojzh5 jwfic4NiVm4svZEdDD2kQNNC8m0Plg5xjxetH+6Uo3aUWfiErTacpSb+UN/zK3hSZ8d3Wo GOgKMKriNmN4+XBxj1GZSNiXNZFTS29CfSkD0aGhZgmaqqmzq++LsDL6yVU0tiL6GN/9NY M0S/1HDLhzzoxONENKEozLg5oFHjrn19kn6l7pUruhAmonC8aXEVbN7Nu9dw X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 7 Jun 2026 19:56:08 -0400 (EDT) Date: Mon, 8 Jun 2026 08:56:04 +0900 From: Michael Paquier To: Erik Rijkers Cc: Daniel Gustafsson , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: doc: Clarify OAuth validator authn_id logging Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ovSX/XEqug/EUOte" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --ovSX/XEqug/EUOte Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 06, 2026 at 02:36:24PM +0200, Erik Rijkers wrote: > In doc/src/sgml/oauth-validators.sgml, and if I understand this text > correctly (always a big if), then: >=20 > "If the validator returns true and set result->authn_id then" >=20 > should be: > "If the validator returns true and sets result->authn_id then" > (i.e., set -> sets) >=20 > (added Michael in CC as he seems to collect these minimal patches, to be > committed later as a group) In auth-oauth.c, there is a validate() path setting the authn_id, so your suggestion sounds right. I've grabbed that for later. My branch can always be overwritten by somebody else's commit preference, of course, so if you feel that this should be fixed separately, feel free to go ahead. -- Michael --ovSX/XEqug/EUOte Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmomBRQACgkQnvQgOdby QH207A/7B46+xsKwQmq8Y0ozOtZ4djkPrBHjlMoHSVwM0FLm5Q6f1mD0gqbxRHSe vifqvAKPyZjbPZH32ZBNuE6GsEIbUjaw9gwLaggYZJ2H64c8wIYL4Zbp04mL+wh/ bu2WstKk+XlWYkZSFIXjjujVtlYsmFg9A7Ma5+JqOmmNzXYmWKD0s6IPqEYk7Shh N/wzGoQTBfQNqEfsf4wFzLNFXak3TJLzPo4AFmfSF3fnMwANyP+pLIyyFcJ7TXGz oCuJym61Jr+iJHQ19Sb4JxJq0n322y/Xq/8A6MT2EUpyBhz+vgq3GnjhBpVXWzIi m6CYOalElMYxBOf3O6AgqoSYMRW/8tGKruGtemrm3RSBfjKhIUJeXIPYmby+Vm32 j/+9lzbKfa1VRlef3ZFH+1ZWQs1TpwtqdzsO9TMn0dxgY7fz6jDTyauKnjMzzyIX L5Y5yNRdYvjo3bdMgpnXbfB28ze8FEXlq1MwFXpVECKPZPAAXXrDpaQi+M6hg9ov R1L9ALRkqEk6RBNKkEp6eoTGLzebVedU41Mp84/sYYyf/0sAr0ZIAZqFkccMovcL B0aGPyBXxCAnW1WJQFzFaATGDVSB+vRtZKYdfFLBqcMSOYZza1wVqUzcza+Yy/8k /swZRNLCmswUnxPZ4Vpx6gss3kSEXJpqFJoyuBAtL0N0DwlB+LU= =F0HM -----END PGP SIGNATURE----- --ovSX/XEqug/EUOte--