public inbox for [email protected]  

help / color / mirror / Atom feed

From: Álvaro Herrera <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Subject: Re: NULL pointer dereference in syslogger with load_libraries() and -DEXEC_BACKEND at startup
Date: Mon, 8 Jun 2026 20:03:35 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2026-May-27, Michael Paquier wrote:

> My first reaction is that we may want to update the two code paths of
> csvlog.c and jsonlog.c with a similar check, switching away from
> MyBackendType to your new syslogger_setup_done.  That would be more
> defensive in the long-term if someone has the idea to refactor or
> reshape this code.

Right, done, thanks.  I tested this by messing with pg_ctl's
004_logrotate.pl; as far as I can tell, it's all working fine.

I did notice that if you have an elog(WARNING) very early in syslogger,
it appears in postmaster's stderr only and not in the log files.  I'm
not fussed about this ... as long as nothing crashes, it's fine.

> It also looks important to me to plant a few comments to document the
> purpose of the flag (which is I'm sure something you were going to
> do).  It is not complicated to see what's the purpose by grepping for
> syslogger_setup_done, but it would be less guessing for the reader.

Yep, done and pushed.

I wondered if the MyBackendType changes could have an effect on
early-startup of other process types, but I couldn't find anything
actionable.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/

view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: NULL pointer dereference in syslogger with load_libraries() and -DEXEC_BACKEND at startup
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox