Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 11 Jun 2026 07:14:33 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: GetBufferDescriptor() being called for local buffers from
 MarkBufferDirtyHint()
Message-ID: <ainhybfghL6I5Ek2@paquier.xyz>
References: 
 <CAExHW5uzRMYVZsXXS3HXXT0fG_sNrpUhUqwP4NorhaCqH9JDhA@mail.gmail.com>
 <aijctocPL6fUibrH@paquier.xyz>
 <hfz3gif4frhxacjsqjjxhcxs4uacgbtrvjwyjzzhejvtj75v65@wq6xllusmmqn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="x0yoJaDu2X6JR/fh"
Content-Disposition: inline
In-Reply-To: <hfz3gif4frhxacjsqjjxhcxs4uacgbtrvjwyjzzhejvtj75v65@wq6xllusmmqn>
Archived-At: 
 <https://www.postgresql.org/message-id/ainhybfghL6I5Ek2%40paquier.xyz>
Precedence: bulk


--x0yoJaDu2X6JR/fh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 10, 2026 at 10:36:22AM -0400, Andres Freund wrote:
> I think it *should* blow up. It doesn't because we're lacking assertions =
in
> GetBufferDescriptor(). But I don't think the assertions added in the patc=
h are
> quite right.
>=20
> We can't trivially add the correct assertions, because somebody though it=
 was
> a good idea to give GetBufferDescriptor() a uint32 parameter, which seems
> completely wrong to me.

This one is not as old as I expected: 3ac88fddd92c.  You're right that
switching that to be signed would be a correct first step forward.
--
Michael

--x0yoJaDu2X6JR/fh
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmop4ckACgkQnvQgOdby
QH2NEA/8CwvTf90gKvIGeB1ne5MqwSHoVE2CExhBxd2BJ9ziJZeczEJmA5kcyXQr
GWeqMQA8m28eHF3pECyv/o0qGRLpzSybjRT9wSDCAZAnnAGBf5S/7eqlZinSiNyR
GniAFPiB7xQ4lpdQQW2uTnO3zHURG1069Awn198S5CzT/pVGw81WBNTeOp8aGMmp
K4xYMgcreZwmNooNj9T9KVmrQpfthNHvyUhfTSS8nB6a4FPqy24bRUC92YFDqf8R
V0uKYPNJm7KwEjkc20pP7rG7saisWi75RVc3CJgN74zFapKU581Lm4J84ALBXcxL
2mXxG7PslHvflF1SChbeYiNb9aNBc8mQ8Q2Ar7soqjF83Gh2anVRwsnjPeloNj1c
J6FlIlYYriJnFQI3jEkkh+rzXqyjiQT0d/gKFaIZ51VrQFMFYZyYX6z9HLYnLnsZ
lpXaRi2x5DpOy5Lyyyhi8Bw6eMmy6NYnO/XtAUp4vvUMfmNc5HSzCE39mH5gXK84
mnpcxtk6DvVkcfVjv9M4/Xj9Tp75y4ESfBZaR0mZhyXPVkODTkb6S2RX7QdqgO1Q
MT0ZKCpxLUt/X9amw4wCebGjJNjOXZKeGq410igUBGvmICVPhA6DF5Tl5o55aBWw
PkeFosiRNaSUYrCYxdBpwt+Zyf1F6uFby8bpsIBp/qI5pk+d54Y=
=918J
-----END PGP SIGNATURE-----

--x0yoJaDu2X6JR/fh--