public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Xuneng Zhou <[email protected]>
Cc: Bertrand Drouvot <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: Alexander Lakhin <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: t/035_standby_logical_decoding.pl might fail on attempt to read wrong timeline
Date: Fri, 12 Jun 2026 11:44:47 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABPTF7WSpNOYu84fjGH2t56BctRzVD7t8WqhgvML2DRh8Vtfog@mail.gmail.com>
References: <CABPTF7WmLKOJcSPod7zT2hynUFQcUs0VoQyR-p=XFsafvmGm7g@mail.gmail.com>
<CABPTF7U_B9pdC563fFONQLX_FXCZtxZgM+jN9snzMVg9b9MRfg@mail.gmail.com>
<aibQB2f9h3nYeg/2@bdtpg>
<CABPTF7XGDgnB97fBUQb+Tm=5NnAzS1iKTWcJTePpGinL1ZAxWQ@mail.gmail.com>
<CABPTF7VovNWnH=dG_A=e6xkMYt11ubbj935Ymfky55cXcWcrrA@mail.gmail.com>
<aifyiJG3uiJzCYTB@bdtpg>
<CABPTF7XAb7ExE-7qSsKgSw3K0hfsNPzXuupQ1aJ8zXOgZ4tPNw@mail.gmail.com>
<aimeoNYE93VLiQHt@bdtpg>
<[email protected]>
<CABPTF7WSpNOYu84fjGH2t56BctRzVD7t8WqhgvML2DRh8Vtfog@mail.gmail.com>
On Fri, Jun 12, 2026 at 08:57:05AM +0800, Xuneng Zhou wrote:
> On Thu, Jun 11, 2026 at 9:15 AM Michael Paquier <[email protected]> wrote:
>> read_local_xlog_page_guts() does not only impact SQL-callable logirep
>> functions, even it is the spot that should be hit most of the time
>> (again, the RecoveryInProgress() vs promotion window is super narrow).
>> At quick glance, things are:
>> - walinspect.
>> - Slot advance.
>> - Slot creation (?), but it feels even narrower.
>
> Yeah, it is used for two-phase commit as well. The usage of it is
> broader than I observed before. Repack worker also make use of it.
Repack workers cannot work on standbys, and for 2PC files we have the
guarantee of a file on disk if the WAL is gone, so they should be
basically irrelevant here. That's why I did not mention them. :)
Everything's now done. I was pondering about v14 and v15 for a bit
for the second patch regarding pg_walinspect (or slot operations), but
I could not get excited about these branches. pg_walinspect is less
used, and slots have much more uses on standbys since v16~, so
expanding that further down feels meh.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (24+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: t/035_standby_logical_decoding.pl might fail on attempt to read wrong timeline
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox