Date: Thu, 25 Jun 2026 11:10:58 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
	Robert Haas <robertmhaas@gmail.com>,
	Roman Eskin <r.eskin@arenadata.io>,
	Michael Paquier <michael@paquier.xyz>,
	Alexander Lakhin <exclusion@gmail.com>,
	pgsql-hackers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Avoid orphaned objects dependencies, take 3
Message-ID: <aj0MwjV1RKV8FvCG@bdtpg>
References: <aie26jMSoEMrHLaI@bdtpg>
 <0fc145b9b5cf3f59207cf4ca60270448a2891c46.camel@j-davis.com>
 <ailZCCmS0bGlNBfe@bdtpg>
 <ail/6I6mcitovsUo@bdtpg>
 <a9eba27eeceebe751490951f0cf631906d4ffd75.camel@j-davis.com>
 <ajEg7PrJYWnmB6zk@bdtpg>
 <ac52a6aa6be9ccf5cf43c44d009b6e2aa7e2c93d.camel@j-davis.com>
 <ajI0Tz9dIJvLGHNY@bdtpg>
 <5591d661ea8189f5c057f6b48095f742e0d772f9.camel@j-davis.com>
 <ajVD9TjerBLteNlx@bdtpg>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="l43bZKrPq3h/RazH"
Content-Disposition: inline
In-Reply-To: <ajVD9TjerBLteNlx@bdtpg>
Archived-At: <https://www.postgresql.org/message-id/aj0MwjV1RKV8FvCG%40bdtpg>
Precedence: bulk


--l43bZKrPq3h/RazH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

On Fri, Jun 19, 2026 at 01:28:21PM +0000, Bertrand Drouvot wrote:
> Hi,
> 
> On Thu, Jun 18, 2026 at 04:21:33PM -0700, Jeff Davis wrote:
> 
> > We could keep the transaction ID in the tracking record, and ignore
> > entries from an aborted subxact. But it's getting fairly complex and
> > delicate.

As discussed off-list, let's move forward with this proposal (as the save a copy
of the object's ACL + ROLE membership mentioned in [1] would be more complex and
fragile).

So PFA the new version doing so. It's the same patch series as the previous one
except that it adds:

0004: Discard ACL tracking entries from aborted subtransactions

It stores SubTransactionId in each AclCheckEntry at recording time.
On subtransaction abort, AtEOSubXact_AclTrack() discards entries whose subxid
is >= the aborting subtransaction's ID.

The code is pretty simple but I suspect that adding a test would probably need to
create a brand new module (say test_acltrack) with C code forcing
recordDependencyOn() and BeginInternalSubTransaction()) and I'm not sure it's
worth it. Indeed, I think the test would need to do things similar to what you
shared in [2].

The patch is split to ease the review but should probably be merged as a single
patch.

[1]: https://postgr.es/m/ajVF7YWf%2Bpxs4cOf%40bdtpg
[2]: https://postgr.es/m/5c629d2455946ad2fde3c184f64ea2c323ef2133.camel@j-davis.com

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

--l43bZKrPq3h/RazH
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v28-0001-Recheck-permissions-after-lock-acquisition-in-de.patch"