public inbox for [email protected]  

help / color / mirror / Atom feed

From: Álvaro Herrera <[email protected]>
To: Masahiko Sawada <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: [email protected]
Cc: Ante Krešić <[email protected]>
Subject: Re: [PATCH] REPLICA IDENTITY USING INDEX accepts column with invalid NOT NULL
Date: Mon, 15 Jun 2026 18:50:54 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2026-Jun-12, Álvaro Herrera wrote:

> On 2026-Jun-11, Masahiko Sawada wrote:
> 
> > It would be better to factor the  into a common function that checks
> > whether the column has a valid NOT NULL constraint, to remove the code
> > duplication.
> 
> I agree, we should have a function like
> bool
> notNullConstraintValidated(Oid relid, AttrNumber attnum)
> in pg_constraint.c, and use it in the various places where we only care
> about the constraint validation status.

I take that back.  I think this change would warrant merging this new
code with the existing verifyNotNullPKCompatible(), which wants to do
pretty much the same; but that's probably a larger refactoring that
should be done in pg20 only.  So maybe we can just do the simple thing
(Ante's patch, mostly, I think) for this backpatchable bug fix, then
change things more fully later on.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] REPLICA IDENTITY USING INDEX accepts column with invalid NOT NULL
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox