Date: Wed, 17 Jun 2026 09:39:18 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
Cc: Hans Buschmann <buschmann@nidsa.net>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: PG19beta1: GCC 16.1.1 =?utf-8?Q?warnin?=
 =?utf-8?B?Zzog4oCYYWN0dWFsX2FyZ190eXBlcw==?= =?utf-8?B?4oCZ?= may be used
 uninitialized in clauses.c
Message-ID: <ajKxliOE7JzBPQiR@nathan>
References: <aiGUxEzo4o5_fRIq@nathan>
 <aiwb1wzWn-q1LNti@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <aiwb1wzWn-q1LNti@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/ajKxliOE7JzBPQiR%40nathan>
Precedence: bulk

On Fri, Jun 12, 2026 at 04:54:04PM +0200, Álvaro Herrera wrote:
> On 2026-Jun-04, Nathan Bossart wrote:
>> This code is ~18 years old, so I'm dubious there's a real problem here.
>> Does something like this suppress the warning?
>> 
>> 	Oid			actual_arg_types[FUNC_MAX_ARGS] = {InvalidOid};
> 
> I agree that it doesn't look like there's a real problem, and that
> something like what you suggest should silence this warning.  I mildly
> prefer to do " = {0}" though, the rules for C incomplete initializers
> being so weird.  But I wouldn't oppose this patch as posted.

WFM.  Hans, can you confirm this fixes the issue?

-- 
nathan