Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1waFTZ-001dW4-0T
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 18 Jun 2026 16:20:21 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1waFTX-00CVo3-0n
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 18 Jun 2026 16:20:19 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <bruce@momjian.us>)
	id 1waFTW-00CVnu-2z
	for pgsql-hackers@lists.postgresql.org;
	Thu, 18 Jun 2026 16:20:18 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <bruce@momjian.us>)
	id 1waFTU-000000017d8-2SJO
	for pgsql-hackers@lists.postgresql.org;
	Thu, 18 Jun 2026 16:20:18 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us;
	s=2026010100; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
	Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
	Content-Description; bh=BGvuEOF0g7KlcODJqIQo5UjrTEIWHd49wa9EB3uuN2M=; b=0zUHd
	heGjiGEpKc970R43mQaefsVGY8PtJKq1USQ/lMeQu2mVvZwhWx6k5V7f1iCp9xAZwuZjhA1J2a8bL
	dyLbv10H++TKP3V/clI/FvW4IR81tHLOZH9rmIcRSqyna95FzY5wxqZFGAUay4hc3vE3VIgjxcI1b
	d9C1MgIx0G1SNJJJTafVDNYl0l1wUo2Gi26blRh8aPw6J9uBdKrrTbwjVTbvZ2sEeLVuNq433+7TG
	PDA1hTQextlZF78muF8by8E7zZYuHg36swdqj88ktMmLZ0XiY9T/pZ+CP7AfXP8rdc8YzObHgyYOY
	eWqxlHIQ8gwB9ye2pL6MCjcScqDCA==;
Received: from bruce by momjian.us with local (Exim 4.98.2)
	(envelope-from <bruce@momjian.us>)
	id 1waFTT-0000000Dsh8-09P1;
	Thu, 18 Jun 2026 12:20:15 -0400
Date: Thu, 18 Jun 2026 12:20:15 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Baji Shaik <baji.pgdev@gmail.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Doc: document standard_conforming_strings dump/restore
 incompatibility
Message-ID: <ajQav8zUY0IHZ0aX@momjian.us>
References: 
 <CA+fm-RM8bG0G6SJDaMgWkKmtyf4QG=V5We1ViAG0tZ5PU67rLQ@mail.gmail.com>
 <1131492.1781717349@sss.pgh.pa.us>
 <ajMvEd0zXBMN-Bri@momjian.us>
 <1242905.1781796886@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="i4CQ6fz0OXesh5b1"
Content-Disposition: inline
In-Reply-To: <1242905.1781796886@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/ajQav8zUY0IHZ0aX%40momjian.us>
Precedence: bulk


--i4CQ6fz0OXesh5b1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jun 18, 2026 at 11:34:46AM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Wed, Jun 17, 2026 at 01:29:09PM -0400, Tom Lane wrote:
> >> I'm inclined to do more or less the attached, which also fixes what
> >> seems a thinko in the existing text: we should say that clients still
> >> support standard_conforming_strings = off, not
> >> escape_string_warning = off.
> 
> > I have applied a slightly modified version to master, attached.  The git
> > commit suggested this problem, but I didn't understand the impact at the
> > time I read it.
> 
> This didn't correct the point I complained of above: it still says
> 
> Client applications still support <literal>escape_string_warning = off</literal> for compatibility with old servers.
> 
> The notion of a client "supporting" escape_string_warning seems quite
> meaningless.  I think this intended to say standard_conforming_strings =
> off.

Ah, yes, I see my mistake now.  Attached patch applied using your wording.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.

--i4CQ6fz0OXesh5b1
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="master.diff"

diff --git a/doc/src/sgml/release-19.sgml b/doc/src/sgml/release-19.sgml
index 7c73cba11b7..96a09d6cd6e 100644
--- a/doc/src/sgml/release-19.sgml
+++ b/doc/src/sgml/release-19.sgml
@@ -116,7 +116,7 @@ or later versions of these applications, or use <literal>standard_conforming_str
 </para>
 
 <para>
-Client applications still support <literal>escape_string_warning = off</literal> for compatibility with old servers.  The server variable <varname>escape_string_warning</varname> has been removed as unnecessary.
+Client applications still support operations with servers having <literal>standard_conforming_strings = off</literal>, for compatibility with old servers.  The server variable <varname>escape_string_warning</varname> has been removed as unnecessary.
 </para>
 </listitem>
 

--i4CQ6fz0OXesh5b1--