public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Fujii Masao <[email protected]>
Cc: JoongHyuk Shin <[email protected]>
Cc: Zsolt Parragi <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Date: Wed, 8 Jul 2026 10:43:53 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHGQGwE7NZJUdvOPg40hYNRcnS=UMohLBtf83W3PRDy1vFXV0A@mail.gmail.com>
References: <CAAAe_zD6oOibLjg6zBs5EvNk2C+y0H7wQVp86z_aGDXJg-sMyg@mail.gmail.com>
<CACSdjfOFz=i2=YT_2kej-+OA0UTyUO1Hc5kEq-2wqzJcmdR6aw@mail.gmail.com>
<[email protected]>
<CAN4CZFMT0gcN5n86U4HBhcq5ppsJP-tjGd2wZGwSLhnXoFODsg@mail.gmail.com>
<[email protected]>
<CACSdjfM9JMFfr0H+fYor5Y7Hkxh8_Ap6_5y=8B9ZoVaOh1CFKQ@mail.gmail.com>
<[email protected]>
<CACSdjfPm+_EE2BTmu7oyW_Gt_7o2eZyNdvaT3fQKbaoKCwGOMQ@mail.gmail.com>
<[email protected]>
<CAHGQGwE7NZJUdvOPg40hYNRcnS=UMohLBtf83W3PRDy1vFXV0A@mail.gmail.com>
On Wed, Jul 08, 2026 at 10:38:54AM +0900, Fujii Masao wrote:
> We can remove assign_recovery_target_name()? With the v8 patch, it only
> assigns the GUC string pointer to recoveryTargetName. It seems we could
> instead have recovery_target_name store its value directly in
> recoveryTargetName, remove recovery_target_name_string, and drop
> the assign hook altogether. Thoughts?
Yeah, perhaps we should just do that. I've also found the consistency
with all these _string variables interesting to keep, but that's
minor compared to less code.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (25+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox