Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 9 Jul 2026 14:28:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ewan Young <kdbase.hack@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Corey Huinker <corey.huinker@gmail.com>
Subject: Re: Reject ill-formed range bounds histograms in
 pg_restore_attribute_stats()
Message-ID: <ak8xbvyBwH0uzOU8@paquier.xyz>
References: 
 <CAON2xHNM809WLR_g0ymKgU-tWxtbyH1Xvh4fqzRqy9YP2A59pg@mail.gmail.com>
 <ak2zIgGdJfyna2-o@paquier.xyz>
 <CAON2xHNGEB=Taga0P-osTcsbWTz6jha9yc74bkx9cASZTueA-g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="UlfU/HcsceYPeox1"
Content-Disposition: inline
In-Reply-To: 
 <CAON2xHNGEB=Taga0P-osTcsbWTz6jha9yc74bkx9cASZTueA-g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ak8xbvyBwH0uzOU8%40paquier.xyz>
Precedence: bulk


--UlfU/HcsceYPeox1
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 08, 2026 at 12:16:27PM +0800, Ewan Young wrote:
> Done in v2.  I moved the check to stat_utils.c as stats_check_bounds_hist=
ogram()
> and now call it from both pg_restore_attribute_stats() and
> pg_restore_extended_stats().  In the extended path I reject an ill-formed
> histogram the same way the sibling stakinds there already do =E2=80=94 WA=
RNING plus
> goto pg_statistic_error.

Thanks.  I have simplified some of the very-talkative comments,
adjusted one place where array_in_safe() was not mentioned (for
extstats expressions we rely on it for NULLs), tweaked a few more
minor things and applied on HEAD.

> Agreed =E2=80=94 v2 targets master only, no back-branch patches.

If somebody has an argument to make here, please feel free.
--
Michael

--UlfU/HcsceYPeox1
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmpPMW4ACgkQnvQgOdby
QH3PKA/6AgUrpb1VlfaWRBASBAgfUv1Auxsze9aCPb53yAHk4TDDwJP+hgiIzYtH
5G+PZaQa94WzcfVfF9LelluHRaHu6WvfnhxRW49NCdlkWGXlwwjrPyEWWWR6ahrv
lORIemn8N5ZbYTR0RNDQ+ZfxdeLmJ7Pl8I0sYDjeHV6lFUITu283cl1naVB+5Lo6
04iVT/I52XaR2mA0jD60lDN5dIVa6eA898W0N0Ckef2mQq3KXLK2VERceYkLlUAX
OWKzPf0F+puooKn93j/2wNkQyrZzosFaJqBKcBkdG0mptFJz3/dbDCMG2y8zfKnd
PBhKbGzO+zZFUWIsoAjrKXspuc8mk43hFFoKRFAyNu/7Xmg1yfooDKZ7dCfYYW7z
Dmk0N9d9fATOHzUF+o6QqaKbJaNtCrx48Ye4BB3XOrK0fmokIy3NXCbzEFKdYM36
A28vmRcNKxVBLXzD0pQMh1Pha6B7X47AAynzf+qUQeYy3BBQSdBgY9JJSLEBNQ3q
XZ1IqU0jxOV4ctYipWl9TqtncjzhOUDs4PtRXdv5oi4O90wQ2vaoYEbcH0JZI6Lh
ViolLHfQTtbeK5JEdTL3og9tRvMZgbk5JrxQNGx9ub8vC+Oqn1w9g69iPljEpzCX
1leGN16zgqBizFZXb4hnOCBIacmc9v9uttTQCkaIE63o/bPTwyM=
=Bwq7
-----END PGP SIGNATURE-----

--UlfU/HcsceYPeox1--