Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1weLVy-004jpo-1j for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Jun 2026 23:35:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1weLVx-005Iei-1S for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Jun 2026 23:35:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1weLVx-005IeY-0a for pgsql-hackers@lists.postgresql.org; Mon, 29 Jun 2026 23:35:45 +0000 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1weLVu-00000000sOB-3mkX for pgsql-hackers@lists.postgresql.org; Mon, 29 Jun 2026 23:35:44 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id 44B911400134; Mon, 29 Jun 2026 19:35:41 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Mon, 29 Jun 2026 19:35:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1782776141; x=1782862541; bh=ukouXxTwzJ p/yTajla+R+GKywFBzg8ndKg2MU9MnHpI=; b=AxO/6E57wCeAM1BxIZgZ0gnkDM zwzx/zw3hFypXgotj9W3Dqv1VsZrME4qsMXFiGKRudsDOW4lsP1+XSIaEi6hQEJJ pPKLL4DvPNW0eDRlm9LbGLSYD07bobp1/mv7F/t0rvu100EbZDuTNOxCApX0rsTl mtJySTNxpguwFrjV5CzeY2MVRSwCcAd0PaMXOqRjnK3BF2DhsKYY8y3+kinDUGHz jdnCsiZec/xGR6mb64plmMKlrG6hJiJif83lKszf8gJhgPhBHMfkgk2aqIYf0z6S OIv4R8Q/9Mkyk4OxBQZIgPWhlpV8OYgNCwk3TxtEpx3d4rJROb9NT7yryuDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1782776141; x=1782862541; bh=ukouXxTwzJp/yTajla+R+GKywFBzg8ndKg2 MU9MnHpI=; b=TnM7ubUgPOFKrYOR0P22CsXHQQKv7NDboukXVXXIGCAXev6RkWh wzDTVcR6Kr9Xt9C18KoriFhRXtCKlQ+kY2Vtdk6JvVXCE2tiuPoUALqTu+mpj8/5 ReG4WgfjC77/rg2d6+0v6xTLn4qdxONdqMF3TNeSQBj1kreUPuBh+0RbTAR+34wE kp6Ekw11n+JYhOjTTOPEqHx/kPiCadbjrAOUQbMwNF+XYtwoqPUa/PJa0eWbELvL uBRijHbB2V5ZrVktGWLfpXUL/FfTVKdCF0fhoaWIm0kKFOuVP7bk7v0w7c0nLYdQ Yg2BEZcKaIxC8dpus1pnEjCD5Uz9Z9YVywA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFmCUhduh3wpl6Y+YQ/PDr2ORAvnDoGJaoUAAGTyEHsafXvc9VUKrM2klMgBiwL7+ ImGO89iuURUaergNc5M1Ll0Ye8P8amcganckAeJec0+GMWueCk2DbkcuclsK/f1PVrAAlO I6f32o0aimniRuWP/hWyYxK+y64tOoQ3m8OXBHdM0pfoezrCgoEUILsssVQpG0sAVsTUbh MiAhJ0E1jpH5qnhpRgttZjJVlnSV+X2RtMnoS4y0igSbsdVLprGEdBzgvpRF+CtuQlHckB Gie8j4a6NYKSHcMx7AwOflM5vm2ANSYDf5ea03T9xmJR6gkt+1qAQVgljOybzh6mA4gMJ0 +TFLBvIwgeTpuTsPusqYrE9HqJiTUmGYfnLFnC6p7d7D36Zw7iyL1a2Xfn2TYQQT6YSuUi ULR7aUrVqu/esL7sVu3EnhWwERdW/APFnKo94iH98HT4l0lqzTKFM03+pZbrBuXJgtk6sv i/brlj2CRogKBx+iaSnevP4MDOk7+9DA6fXq3txZiw1PgCyt8vADaQdHZPmjSz5shaOMFe 1xjXtsTLWvyWy1Q/rzgi0JHQXIyINixlVOOXBmfxXPZjJ7UatsiZ7K0XydeZ1XEcM9FZ0Y LV8J9FNWhm6zSLFIrTgeGOJWAaCqOesJAuV7QRNZTl9jGABGHVYliUYbEpXA X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Jun 2026 19:35:40 -0400 (EDT) Date: Tue, 30 Jun 2026 08:35:36 +0900 From: Michael Paquier To: Zsolt Parragi Cc: pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks Message-ID: References: <0WrsV1VojwurDot6hdS0norm0nK9QFDk0KSLqBcXK4Xz2b_sMuIdE0zyiXP0p1hTRD7Hwz3C8AQouGyV7yZMhf5joz3zUpQee3l_pWPs4dk=@scottray.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iWh8NgBSIFb7q5uq" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --iWh8NgBSIFb7q5uq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 29, 2026 at 04:16:59PM -0500, Zsolt Parragi wrote: > Isn't mentioning pg_settings confusing instead of helpful during a > server restart? With a reload it can help, but when the server can't > start, hinting that the user should query pg_settings doesn't seem > that useful. Yeah, it is. I don't see a reason why we should be specific about the location where these parameters are set. One has been setting up recovery parameters in the GUC machine, so they most likely know where these strings are. -- Michael --iWh8NgBSIFb7q5uq Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmpDAUgACgkQnvQgOdby QH0d8A/9HpuPXclk8lfutVSvB0mlPD0OJl7ck33xTw+FSLPLz8lxjAszmqwr4vaB fCfN8CWJNLDdo7yt3QTuRx4tmw5hd1wHOIHMaqC2yzT26SGKyc4Q8L/suIltZUlG 2m6iR1P/VSp46nUm+K+WJmT3rLbW7vCMlmacT092y23XIAidhi78k+PvXQAKgWAy axHfP2sVFw0OZZfefXuz/3u+aTGDVyT6g4BgM59M6HZG89LfApYYa/p7gjtFOI6o EKoePOvYFbUyVAl/AtobAjCFWi4sAa7Q7mB9dNG0Z/TP85+aJDKrbkavic8bLoCx iy60OLbtQYb5tJVMEa03BuX7VTFrrdSDU9fmAuJmwpMYPQz6t4uvIvaijqy7beUW dDmfuew1XKB0/qlMtmrBBK4FRcbZfic+FbKuszCzT7axMYW88RwOm9rInr77twC0 y8CiHcxEKaP+v1E4YGy6ai2WwqSiDEvKD/GzA5RIVGdgerejB3P/f0a1l2D6nKNA pPK+E5LL7NgnZzdZWAOnCbyr71q6xsS0UXrY1Z04HrLQ6Jnowi4aCmahwqmJGRNe q5E+/388wqCjR/sTUmaTIliIw0+Ei7AGWr6Xk9kOloR1rLP0Z1sWPksyWkxBd8MS RsxDJzq1zwQ5WqY4YqI/sf3PaeeycBXFtHFDEmxn1rg13aaT/EA= =bLAt -----END PGP SIGNATURE----- --iWh8NgBSIFb7q5uq--