public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 15/18] doc review for multiranges
8+ messages / 3 participants
[nested] [flat]
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10
@ 2026-06-11 14:21 Nathan Bossart <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Nathan Bossart @ 2026-06-11 14:21 UTC (permalink / raw)
To: Andrew Dunstan <[email protected]>; +Cc: Tom Lane <[email protected]>; Corey Huinker <[email protected]>; pgsql-hackers
rebased
--
nathan
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10
@ 2026-06-29 15:16 Nathan Bossart <[email protected]>
parent: Nathan Bossart <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Nathan Bossart @ 2026-06-29 15:16 UTC (permalink / raw)
To: Andrew Dunstan <[email protected]>; +Cc: Tom Lane <[email protected]>; Corey Huinker <[email protected]>; pgsql-hackers
rebased
--
nathan
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10
@ 2026-06-30 03:36 Fujii Masao <[email protected]>
parent: Nathan Bossart <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Fujii Masao @ 2026-06-30 03:36 UTC (permalink / raw)
To: Nathan Bossart <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; Tom Lane <[email protected]>; Corey Huinker <[email protected]>; pgsql-hackers
On Tue, Jun 30, 2026 at 12:16 AM Nathan Bossart
<[email protected]> wrote:
>
> rebased
Thanks for updating the patches!
Regarding 0001 patch:
Wouldn't it make sense to document the minimum supported server
version also in the pg_dumpall docs?
/*
* We allow the server to be back to 9.2, and up to any minor release of
* our own major version. (See also version check in pg_dump.c.)
*/
if (my_version != server_version_temp
&& (server_version_temp < 90200 ||
(server_version_temp / 100) > (my_version / 100)))
Shouldn't this be updated as well?
Regarding 0002 patch:
- if (GET_MAJOR_VERSION(old_cluster.major_version) < 902)
+ if (GET_MAJOR_VERSION(old_cluster.major_version) < 10)
Shouldn't this be "< 1000" instead of "< 10"?
According to the following git grep results, there still seem to be
several code paths for pre-v10 support. Should those also be updated or
removed?
$ git grep -E "GET_MAJOR_VERSION.* 9"
src/bin/pg_upgrade/controldata.c: if
(GET_MAJOR_VERSION(cluster->bin_version) <= 906)
src/bin/pg_upgrade/controldata.c: if
(GET_MAJOR_VERSION(cluster->major_version) <= 902)
src/bin/pg_upgrade/controldata.c: else if
(GET_MAJOR_VERSION(cluster->major_version) >= 906)
src/bin/pg_upgrade/controldata.c: if
(GET_MAJOR_VERSION(cluster->major_version) <= 902)
src/bin/pg_upgrade/server.c:
(GET_MAJOR_VERSION(cluster->major_version) <= 902) ?
# --swap can't be used to upgrade from versions older than 10, so just skip
# the test if the old cluster version is too old.
if ($old->pg_version < 10 && $mode eq "--swap")
In pg_upgrade/t/006_transfer_modes.pl, shouldn't this simply be
"if ($old->pg_version < 10)" so that the test is skipped whenever
the old cluster is pre-v10?
Regarding 0003 patch:
/*
* These object types were introduced later than our support cutoff of
* server version 9.2. We use the VersionedQuery infrastructure so that
* we don't send certain-to-fail queries to older servers.
*/
In psql/tab-complete.in.c, shouldn't this comment be updated as well?
Overall, the following git grep results seem to suggest that there are several
comments referring to pre-v10 support that may also need updating:
$ git grep " 9\.[0-6]" | grep -E "pg_dump|pg_upgrade|psql" | grep -v "\.po:"
Regards,
--
Fujii Masao
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10
@ 2026-06-30 20:18 Nathan Bossart <[email protected]>
parent: Fujii Masao <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Nathan Bossart @ 2026-06-30 20:18 UTC (permalink / raw)
To: Fujii Masao <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; Tom Lane <[email protected]>; Corey Huinker <[email protected]>; pgsql-hackers
On Tue, Jun 30, 2026 at 12:36:39PM +0900, Fujii Masao wrote:
> Thanks for updating the patches!
Appreciate the review.
> Regarding 0001 patch:
>
> Wouldn't it make sense to document the minimum supported server
> version also in the pg_dumpall docs?
Yes, I think so. However, since that's an additive change and not directly
related to $subject, I'd like to tackle it separately. Folks might have
preferences on the wording.
> /*
> * We allow the server to be back to 9.2, and up to any minor release of
> * our own major version. (See also version check in pg_dump.c.)
> */
> if (my_version != server_version_temp
> && (server_version_temp < 90200 ||
> (server_version_temp / 100) > (my_version / 100)))
>
> Shouldn't this be updated as well?
Oops, yes.
> Regarding 0002 patch:
>
> - if (GET_MAJOR_VERSION(old_cluster.major_version) < 902)
> + if (GET_MAJOR_VERSION(old_cluster.major_version) < 10)
>
> Shouldn't this be "< 1000" instead of "< 10"?
Yes.
> According to the following git grep results, there still seem to be
> several code paths for pre-v10 support. Should those also be updated or
> removed?
>
> $ git grep -E "GET_MAJOR_VERSION.* 9"
> src/bin/pg_upgrade/controldata.c: if
> (GET_MAJOR_VERSION(cluster->bin_version) <= 906)
> src/bin/pg_upgrade/controldata.c: if
> (GET_MAJOR_VERSION(cluster->major_version) <= 902)
> src/bin/pg_upgrade/controldata.c: else if
> (GET_MAJOR_VERSION(cluster->major_version) >= 906)
> src/bin/pg_upgrade/controldata.c: if
> (GET_MAJOR_VERSION(cluster->major_version) <= 902)
> src/bin/pg_upgrade/server.c:
> (GET_MAJOR_VERSION(cluster->major_version) <= 902) ?
Fixed. I thought I had handled these, but apparently they got lost
somewhere.
> # --swap can't be used to upgrade from versions older than 10, so just skip
> # the test if the old cluster version is too old.
> if ($old->pg_version < 10 && $mode eq "--swap")
>
> In pg_upgrade/t/006_transfer_modes.pl, shouldn't this simply be
> "if ($old->pg_version < 10)" so that the test is skipped whenever
> the old cluster is pre-v10?
I think we can remove it entirely. We don't block for <v9.2 today, so I
see no need to make it robust against invalid test setups.
> Regarding 0003 patch:
>
> /*
> * These object types were introduced later than our support cutoff of
> * server version 9.2. We use the VersionedQuery infrastructure so that
> * we don't send certain-to-fail queries to older servers.
> */
>
> In psql/tab-complete.in.c, shouldn't this comment be updated as well?
This also got lost along the way. Fixed.
> Overall, the following git grep results seem to suggest that there are several
> comments referring to pre-v10 support that may also need updating:
>
> $ git grep " 9\.[0-6]" | grep -E "pg_dump|pg_upgrade|psql" | grep -v "\.po:"
I didn't see anything else that I thought obviously needed to be changed.
Please let me know if you feel otherwise.
--
nathan
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10
@ 2026-07-01 15:55 Nathan Bossart <[email protected]>
parent: Nathan Bossart <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Nathan Bossart @ 2026-07-01 15:55 UTC (permalink / raw)
To: Fujii Masao <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; Tom Lane <[email protected]>; Corey Huinker <[email protected]>; pgsql-hackers
On Tue, Jun 30, 2026 at 03:18:51PM -0500, Nathan Bossart wrote:
> I didn't see anything else that I thought obviously needed to be changed.
> Please let me know if you feel otherwise.
FTR I'm planning to commit this tomorrow.
--
nathan
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10
@ 2026-07-02 18:11 Nathan Bossart <[email protected]>
parent: Nathan Bossart <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Nathan Bossart @ 2026-07-02 18:11 UTC (permalink / raw)
To: Fujii Masao <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; Tom Lane <[email protected]>; Corey Huinker <[email protected]>; pgsql-hackers
On Wed, Jul 01, 2026 at 10:55:01AM -0500, Nathan Bossart wrote:
> FTR I'm planning to commit this tomorrow.
Committed.
--
nathan
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10
@ 2026-07-08 21:43 Nathan Bossart <[email protected]>
parent: Nathan Bossart <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Nathan Bossart @ 2026-07-08 21:43 UTC (permalink / raw)
To: Fujii Masao <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; Tom Lane <[email protected]>; Corey Huinker <[email protected]>; pgsql-hackers
I just noticed that I forgot to update AdjustUpgrade.pm accordingly.
Here's a patch.
--
nathan
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2026-07-08 21:43 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2026-06-11 14:21 Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10 Nathan Bossart <[email protected]>
2026-06-29 15:16 ` Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10 Nathan Bossart <[email protected]>
2026-06-30 03:36 ` Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10 Fujii Masao <[email protected]>
2026-06-30 20:18 ` Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10 Nathan Bossart <[email protected]>
2026-07-01 15:55 ` Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10 Nathan Bossart <[email protected]>
2026-07-02 18:11 ` Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10 Nathan Bossart <[email protected]>
2026-07-08 21:43 ` Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10 Nathan Bossart <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox