Feedback-ID: ie3de48e3:Fastmail
Date: Fri, 3 Jul 2026 22:17:31 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: "Jonathan Gonzalez V." <jonathan.abdiel@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Coverage (lcov) failing with inconsistent error in versions 2.x
Message-ID: <akgWI8Cixc9b_7uB@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAOYmi+kw+LL82qjiBmwrigk85fKcBn++UtVKAEcDRRWn3ZXy=Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/akgWI8Cixc9b_7uB%40alvherre.pgsql>
Precedence: bulk

On 2026-Jul-01, Jacob Champion wrote:

> We could rewrite https://wiki.postgresql.org/wiki/CodeCoverage, maybe.

We could rewrite it, yes, but lower effort for me today was to _reread_
it, and in doing so I realized that we disabled branch reporting seven
years ago while we waited for a new GCC version; that fixed GCC version
being now ancient history, I have reenabled branch coverage.

One totally not funny thing is that with that enabled, lcov fails in
even more interesting ways; now you need to give "inconsistent,mismatch"
in LCOVFLAGS.  So the whole thing is

make coverage-html LCOVFLAGS="-q -j0 --ignore-errors usage,negative,inconsistent,mismatch" GENHTML_FLAGS="-q -j0 --legend --ignore-errors unmapped,corrupt,inconsistent,range"


I added -j0 to both so that they run parallel processes, which should be
a few second faster.  In practice it may make no difference, because the
real time eater is the xid_wraparound test, which lasts for 10 minutes
after all the other tests have completed:

# +++ tap check in src/test/modules/xid_wraparound +++
t/002_limits.pl ............ ok
t/004_notify_freeze.pl ..... ok
t/001_emergency_vacuum.pl .. ok
t/003_wraparounds.pl ....... ok
All tests successful.
Files=4, Tests=23, 415 wallclock secs ( 0.04 usr  0.00 sys +  7.31 cusr 3.81 csys = 11.16 CPU)
Result: PASS


Regards

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Uno puede defenderse de los ataques; contra los elogios se esta indefenso"