Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wgrps-006Srh-0O for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Jul 2026 22:30:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wgrpr-003Pne-0C for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Jul 2026 22:30:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wgrpq-003PnT-0R for pgsql-hackers@lists.postgresql.org; Mon, 06 Jul 2026 22:30:42 +0000 Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wgrpn-00000001urb-3wKT for pgsql-hackers@lists.postgresql.org; Mon, 06 Jul 2026 22:30:41 +0000 Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id 6186F1D001BC; Mon, 6 Jul 2026 18:30:38 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Mon, 06 Jul 2026 18:30:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1783377038; x=1783463438; bh=U2afRRotRr fssD4kBssmJDK3FqET2Zo7YrUoLIFQNG0=; b=hQxj/rKXXonUoqUSOYbzG3F4gA Pvvj6riZNE+YTODbWub80MeNSKaDuXqoiebPkOv7txstqCad60zLaAwASQmH0BWE bvOzScLRA4bEe60wZQJwwgu6S8420RkKI5OA5p/YNuHcVDR7/BTXjdP+2e45pi0Z /ahctmodIgaSPLo3BBFwwaSJTHX6rdCtfjaZsBhd0HcnReXglBz8IAljND+OqMmz S+t4GrTcqocvluy0XGN4HAAC6qim3sfKs04tRePI9t6FT/OPjBYrOXPVjrISTj2Y 27ipDSlUsYaBsaoSOxkxbV5WzJ0w2RCAwLwJypIG2xjhu8fLrmS7CCYaPmtA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1783377038; x=1783463438; bh=U2afRRotRrfssD4kBssmJDK3FqET2Zo7YrU oLIFQNG0=; b=pVwP2Cf95Ey4mq5EMI2ARLSPxqR5yDTucS7hlbpRaW6Ktw51+CJ 8Zdd0GdP6EVJV/z2Jq9ssgCSYAt3OAwjA7FE4eE39xQnF5Dr2FYNj6lX+c6Vz87q EF2dCIJaePexWRSDIG/uIEFV+HhCWPf5EYnF8rCdTAX8wZACKELxD0+HT+NB1kzF XExeW85bN3usOwDYEiRrZXh+ofxxYuauQ4f2htbqdYYo4hxZ2TyIeRCRcyLuXFrM RB0Q5dc+smePriTgrlbYjlyo/QtmZWumMJpxI4OF3jTW7v6FEAgMOAOkzvLtP/g0 DauDJx61PbWnBYGmeiF2vjI5SSs0uqFx2RA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFyS2ts8pZfwKGiAI2pKd0SKV9j5JmYBuWgdUGxOoxCeJJjNMABSXh9oD4YA/gf9Q fH0ZXAGgsJp+rep5VnFJ0+ouRXsMvupzPKZUVSQbFvTMAAmNzRBMVybuvSo30Ee2FOnLrA tTOZdTGuHOvYZElRoscJgUzD0+bVikr/Aol1qjj6whq47hPCsXGINhzhKQRfN/RpDu4ssG 7K2WDI40WEeda7l0SVnFcDKrMgVYvCCFZGLrtSIraDAO9wss6TnmxCP0oeK7+zR12vvUeQ OnDm3Xevgng7YqM+wc1bZqfDu5Ham2NPw3s0GUf2vRfYRvaqNzR7UnalRAVf1zTzJmOfo/ 9sF/dcUjJyFDBQ/304kDLqDjUuZZfJMfVj22MZKqU4mp/6nUMmR4rizxqAQoxYQJFftYMJ HLDoL8mVYpntn/N2isWagbJkjLZ6IUBraFACiFTmiJtwP0bhqX+PasrYKhPdJlbudiFMkX bpQK3afnSL1kkzP5793mstJJA6KZUR9+nchso4y4jdHJmK8LVqx56IbrqBBi3WocO/CKwd tlfRzwvLiWJlDm4ctzJnK4Kj6X5zWG8h0J8NOyxlXFaZ8x5XqVCsMkhIax0wFBjiz2jIVw +E3z0uk+ZxFEJdqJBWciyIP9WHsM0ixXMp8ypKdXZO2eRldgx2xjKMSMahYg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Jul 2026 18:30:36 -0400 (EDT) Date: Tue, 7 Jul 2026 07:30:32 +0900 From: Michael Paquier To: JoongHyuk Shin Cc: Zsolt Parragi , pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7/8wEByDyYHPygDD" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --7/8wEByDyYHPygDD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 06, 2026 at 04:53:44PM +0900, JoongHyuk Shin wrote: > I would rather drop the errhint from this patch entirely than fold it into > the errdetail. > Any objections? Sounds good here to remove the errhint(). No hint is better than a potentially wrong hint. Thanks. -- Michael --7/8wEByDyYHPygDD Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmpMLIgACgkQnvQgOdby QH0SvQ//UAdGReL8sOVPE1IYSk8hWvXSARONTyU40Ml1qRh2DAEq8MISOQXLPqUh FO5uskN4eJ2a/p0UTo2+rg2gMqjKA52zG9Hr61fYDUz08QDmQCwUMI8AaQiOUtOS JzPayH2CDq5+1z/inMIhC9Y487igIP8LYPm41AlSngUoGOFzMoeLzGllT8UWulEx aKGlZ+nwiAjqam204dUNjQK3cBs3Err+WZ3Fxh/Ye74SXIF9fUBILJMDkgm1FqZ2 s9/Ry+fvtquzqq1IPTHSDsGdCXf+x5dWnl3D2AdTCMgYQiK9fpWlXM97EzqSOA9U 1FjV0KQ1WonRGTcN1e08nou/jkwj+1Dc32jDQmAcvUBMt8xHMvfPp366QPUggmFI hj68F6/K8kQwEJrT3rTOetn5Qvme7s9184kYgT+ZG7H8NZsiVfAnlKjfrYkI2a5b 7QCVLiMkkRy6PvSy0nFKg3L3ww40ZJKnAtWKmauzUZG+AnDcs8dOmijgr2sFflh8 r0HfWOCuBt0/K5KvRHJL5ktw6+Hlu+aDUxh3DHeU/SOVTHZ2Ak2M3kfPUN2hCvjU BFyXxxapx0oscCG/HO6TSzRT0iynZ+t2sXQ1D+1xi1FdFzwuDcFzbNR4ftHasDkm 7aHUcIqchFB/3nW0+k3JGJHCJycUnTeX4UFY9qS0sfTSa2X675g= =ugb9 -----END PGP SIGNATURE----- --7/8wEByDyYHPygDD--