Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wll6P-000MvQ-1o for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Jul 2026 10:20:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wll6P-002sXJ-0a for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Jul 2026 10:20:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wll6O-002sXB-0a for pgsql-hackers@lists.postgresql.org; Mon, 20 Jul 2026 10:20:00 +0000 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wll6K-0000000165K-3tji for pgsql-hackers@lists.postgresql.org; Mon, 20 Jul 2026 10:19:58 +0000 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id 20DA51400103; Mon, 20 Jul 2026 06:19:56 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Mon, 20 Jul 2026 06:19:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm1; t=1784542796; x= 1784629196; bh=lxZ3X25VlNX6H9BIFVMsXWNrRFMK6SLv7p4gK4xPl4M=; b=A qZc740W/8dL0KrVM11qkvKvcpPYWpzu3tw+mFxhUZh/uvjJmQmoYVWfG9z1fKIjA pKvagHMm1oBKWT7h3mwmdttOPMJIJJ+to9d53CFLq+pWgoAB8juMGyL1YGNqBJLY Qt0TLsIbwWeFxXI2CneORuO0/EEPcdLOJFO4G4S4XmzsxxY+a1d3IB5p42HOqhIK ir2+pSb9IjSLJzC0DFJY6khXPzqHIXyAnziObUVxV6ntO5F+cK/cVeWaV6yu9x07 UqvNuyE8a0QTYGyV7pSloQhLDthq3MafrilKQzwgyV/Lv4mfheBeK29ZR2q1wD17 VkMxb6HEz8k266Sy65IAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1784542796; x=1784629196; bh=l xZ3X25VlNX6H9BIFVMsXWNrRFMK6SLv7p4gK4xPl4M=; b=WI7rbhoMEG59jAC8P 5NYETdTDFk/k43+Mdl1KUmLfQvkP61oIN6ceNCsyrysI1qh6cDp4yMFDR5shqAog ngow7NmSVxUoaoVWh5/bVD8VbwgwhISFg1Gd+HwDEfw0FMc9R3m3ngAb1Ad4ls0N 49M0g9AwtMPgaJSrockWtx3nlUQI5MhGDyDXYZqlxli8LwtIliNpx34gpTZSAVfm IiNmqju8jfCjoVdHQnrVaxbDRa5nywAMxt+xSmBS7JzOjIQ/rOYr8nkyi0Q4EMgF lAWbRVg2PYAwd6dFCTTTbnPzVToD6+NU6kQxbBbBobn9aD9rCjQULaEGJxc/Yusv JZY2g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGnNzuxVmr+rq7NBXXWSUzsLuoRSS9qzWdjh5q9dGJgf4C719LnBonFPQgXMdflDq ac5mRxZBHSQ0M9b3WdHYPPhzYi08nwi3E9vE6hsUP/6s4XLHp5M9mFszxlfFzAWuXH1XJN 96QqjwUviRsw0+YIL0/+0KMnnsglPUXQnyep9eI41L5VajIz6RBrVvN8Ff4+GbXJtXspyD Mb997P673jSIHJpGFaCVe+BFi5CQIHcdoNQWkuZcAVdzwiXT/6jvnGTb+CqasyUEe9I5bY N1WehpsDqtHEdjyybQeeZ1MAcuaC6cM8KtfEwTF+op/LGFYMg1Cr35PkgKUoEaU/GPL0ih x90KTSWkQRmtqXhuXrcRjaTXLWSRJMEMjr/apnhO/Fv2Wl9ohFa+RXMBvx9P3BdNOd398a cLELV08mBowrSuz24Svp1QHF+5rVFvWfne8yW17tsVsB2CA5e45YlluN0aTUIHiGZUKtSG 7F2R7goWmf2OsPiwasKr74DdDviwLY8u8gDFal2LQQLfDOwaH0RmLHOyaRM87805IK2OXb 5YXmMd+v157GKR4QLrXN3pleIAVC8ktpM3KFhT2ZzDXbJWeHoGagnradEaZZZqjzXUx6SS kwYtdg0u0JXEnHf9w+byrTWoL8+omktaaqhsQVubZAgmDLuwQzeFUUh1uVHw X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Jul 2026 06:19:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1784542792; bh=YE5QXAVKuL11rojOwERCuNia4Wpg7XB6XNa5B372/co=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=yjTm9Oxhqc99JjHe0ASGk9BzxbTuSbcp9ffMCNDpsuNLRA4RGkHJlezv3o/HUDXYX +5bncEAnF7UQzhlsh6scvZFP5TzAWUVQe5vUTMlBgU844mZ/MGLofy8d4NADKSsN1W gdn6TTg9VWE7KsZEuT30+DmF344hODjbKJ8do68SYSmGc+lbs5+XPgfr/7ZEAJTX2q d/DaYbtpgGaqYrDbLwcNk/T55YEx3tIGr2zae6+4HkTSLs0SFRyJaiY9atLK/fEijp EttcpcMk1mkCDMNuGU0x03eM8bVaQLXnaKPif1zWhQD7SzQdQ5Gz5f/rqlByPn/PBZ NVH1CeNoM+1/Q== Received: by ida.kurilemu.internal (Postfix, from userid 1000) id F04B9B00805; Mon, 20 Jul 2026 12:19:52 +0200 (CEST) Date: Mon, 20 Jul 2026 12:19:52 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: cca5507 Cc: Bharath Rupireddy , pgsql-hackers Subject: Re: Do not lock tables in get_tables_to_repack Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2026-Jul-11, cca5507 wrote: > Bharath Rupireddy wrote: > > + table_oid = IndexGetRelation(child_oid, true); > > + if (!OidIsValid(table_oid)) > > + continue; > > > > How about a short comment on why this is needed even with a lock on > > the parent, since that lock doesn't cover lower-level leaves in a > > multi-level partition tree? > > I think it's worth a comment, too. Patch LGTM. Thanks, added that and pushed. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Puedes vivir sólo una vez, pero si lo haces bien, una vez es suficiente"