Feedback-ID: ie3de48e3:Fastmail
Date: Fri, 10 Jul 2026 16:22:04 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: cca5507 <cca5507@qq.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Do not lock tables in get_tables_to_repack
Message-ID: <alD9l-XlCuu3eUEe@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="f4uihmgjmvhgvze3"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <tencent_39EA60C72E2394B930B416286544061F8F05@qq.com>
Archived-At: 
 <https://www.postgresql.org/message-id/alD9l-XlCuu3eUEe%40alvherre.pgsql>
Precedence: bulk


--f4uihmgjmvhgvze3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2026-Jul-08, cca5507 wrote:

> -                       classtup = SearchSysCache1(RELOID, ObjectIdGetDatum(index->indrelid));
> +                       classtup = SearchSysCacheCopy1(RELOID, ObjectIdGetDatum(index->indrelid));
> 
> Do we really need to copy it? We hold a refcount on it so it won't be freed
> until we release it. Otherwise LGTM.

Yeah, I guess it doesn't matter.  I have removed the copy and updated
some comments.  I also realized that there are some places where we
weren't dealing correctly with the possibility that the relation goes
away, or is replaced with something different, so I added that too.

While looking at it I also realized that get_tables_to_repack_partitioned
is likewise not careful enough about it: we do IndexGetRelation(, false)
which fails hard if the pg_index tuple cannot be found, which is the
wrong thing to do.

At the same time, it's annoying that half of the code that clearly
belongs in that routine is actually in ExecRepack().  I moved that to
where it rightfully belongs.  (The only somewhat annoying thing is that
we have to NULL-out the Relation pointer after returning; but that's not
*too* bad IMO.)

Any opinions on this?

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"No me acuerdo, pero no es cierto.  No es cierto, y si fuera cierto,
 no me acuerdo."                 (Augusto Pinochet a una corte de justicia)

--f4uihmgjmvhgvze3
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename=0001-change-get_tables_to_repack_partitioned.patch