Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 11 Jul 2026 19:10:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
	Kirill Reshke <reshkekirill@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: relfilenode statistics
Message-ID: <alIWgtRb_ZMiCMFf@paquier.xyz>
References: <ezbfcpjtfh3vtm667aegyrptcdsvinbuxw6y5p6j3e5fbffrl5@i7v6cjapz3yv>
 <aUELPdhdcyzTM_8K@paquier.xyz>
 <zferux2jlbhqymubzhpubfrkjzhzxzguq4eprtycojtif5vbqh@2t7cu2teyqmi>
 <aWYQXiKgIIvrlyVi@ip-10-97-1-34.eu-west-3.compute.internal>
 <aZv2B8CFJZTKEl8j@ip-10-97-1-34.eu-west-3.compute.internal>
 <aa56L2wM16VldK5f@ip-10-97-1-34.eu-west-3.compute.internal>
 <alCLr8ya-4ojew-x@paquier.xyz>
 <74242uhjpufa2tsb6dqot7cvhhyxjbhfo273wpooo6hizbdg6o@f45d72gt2ujb>
 <alG8F9lVldB3WseN@paquier.xyz>
 <alHDjQcMJKGhE2l3@bdtpg>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="LgLhLaYMoJBPvAkc"
Content-Disposition: inline
In-Reply-To: <alHDjQcMJKGhE2l3@bdtpg>
Archived-At: 
 <https://www.postgresql.org/message-id/alIWgtRb_ZMiCMFf%40paquier.xyz>
Precedence: bulk

--LgLhLaYMoJBPvAkc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jul 11, 2026 at 04:16:13AM +0000, Bertrand Drouvot wrote:
> Maybe resume this thread [1] instead of creating a new one? It's in this =
thread
> that it has been suggested to start with relfilenode stats first [2] but =
that
> was due to the design of the patch at that time that may not apply to you=
rs (did
> not look at it yet).
>=20
> [1]: https://postgr.es/m/f572abe7-a1bb-e13b-48c7-2ca150546822%40gmail.com
> [2]: https://postgr.es/m/20230105002733.ealhzubjaiqis6ua%40awork3.anaraze=
l.de

Honestly, I don't know which way is the best.  This was 3 years ago so
starting afresh may be better at the end.  Please note that I have
spent a couple of hours eyeing at your previous patch, where I'd like
to think that I have found an approach with a better balance,
finishing by being less invasive.  The two main points are 1) the
handling of the xact data for a split for the fields we care about and
2) a union structure felt less intrusive, but these two points really
come down to where you want to put a separation line.  Another side thing
is the renaming of the SQL functions for non-index relkinds, your
patch using *_tab_*.
--
Michael

--LgLhLaYMoJBPvAkc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmpSFoIACgkQnvQgOdby
QH20vA//TOIlv21UiUGapSXNMZ/fbCW7+4Efa9/2RsnxiHXLYK85n9mZvlBIyu5u
zLOrdxH1kmwu2pjgRfwe4N920+hPLUja1iGHjx0tI5fbs4nq48Lq+8YUiTTJW2FJ
MehA44uK7MTCPznfKqhpQUDA01sVXRX5KYPXZ6M7+/+Cdzdu8WDUZFiPvD3mdTCY
r4olOws7Go/C2FzBOZbPENcoBzyKJ1B45cTVxPklxxQzMBbhi5q+P5jrAFTLxMvP
H43wUjTkW1UU8woW8JPqT4D3sKFfQu3dL6lKlNmJN+WLaQu4qt0JDH9sGkx4v538
tq64b0jJGzcAC4JFiNevuPNETJteUOZajkrrgOfDW93xlYpW2lCesGjtIhC6xkI0
m+/OMrFbwQ18CyIM2xpl+vfbfHmltt0CP6uLdwMMjtmh27t4zbWZFxCaYf1k0n8t
Ojjtq80Ab6K9ZT5jpb4cuPWA96YcATiGvEqt2xm3nywLeTPDNYKylxF3r+gDfT01
jPbcqXnRa9ZaxjT0eNdXfx21EMLCwRS+/IbQybmfsMZ6M2R8N6wJzirZtgZNpKZ7
Woa6pI2uwBAAZZJvvsP1RqcYlX+dxP3nXA1DUwQEey66xnceJOnxD2O0cBFZr/aq
RJGQI9sxGztyVEL30gzCJU0E7KLqJjl+tqPXQFb0SkIWDwc9P1U=
=FUls
-----END PGP SIGNATURE-----

--LgLhLaYMoJBPvAkc--