Feedback-ID: ie3de48e3:Fastmail
Date: Wed, 15 Jul 2026 18:14:30 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Anton Voloshin <a.voloshin@postgrespro.ru>
Cc: Michael Paquier <michael@paquier.xyz>,
	Euler Taveira <euler@eulerto.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: NULL pointer dereference in syslogger with load_libraries() and
 -DEXEC_BACKEND at startup
Message-ID: <alew9Lk3BXiGZsm7@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4ccb96f8-0bac-4362-ac22-2f81d1b0062c@postgrespro.ru>
Archived-At: 
 <https://www.postgresql.org/message-id/alew9Lk3BXiGZsm7%40alvherre.pgsql>
Precedence: bulk

On 2026-Jul-15, Anton Voloshin wrote:

> On 08/06/2026 21:03, Álvaro Herrera wrote:
> 
> > --- a/src/include/postmaster/syslogger.h
> > +++ b/src/include/postmaster/syslogger.h
> > @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2];
> >  extern PGDLLIMPORT HANDLE syslogPipe[2];
> >  #endif
> >
> > +extern bool syslogger_setup_done;
> 
> Shouldn't this be extern *PGDLLIMPORT* bool ... ?

Hmm, does that export the symbol so that third-party code can get at it?
I'm not sure it makes sense to do it for this one symbol, which should
be internal business between syslogger and elog only.

Did you hit a problem with it?  If so, what was it?

Michael, looking at 
https://github.com/michaelpq/pg_plugins/blob/main/jsonlog/jsonlog.c
do you see an issue with this variable?

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La espina, desde que nace, ya pincha" (Proverbio africano)