Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M277708=pgsql-hackers-arkari@postgresql.org>)
 id 1ZHyvk-0004lR-Hs
 for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Jul 2015 18:39:48 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.84) (envelope-from
 <pgsql-hackers-owner+M277708=pgsql-hackers-arkari@postgresql.org>)
 id 1ZHyvk-0005kD-3k
 for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Jul 2015 18:39:48 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
 by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
 (Exim 4.84) (envelope-from <coelho@cri.ensmp.fr>) id 1ZHyvj-0005hm-6K
 for pgsql-hackers@postgresql.org; Wed, 22 Jul 2015 18:39:47 +0000
Received: from boipeva.ensmp.fr ([194.214.158.136])
 by makus.postgresql.org with esmtp (Exim 4.84)
 (envelope-from <coelho@cri.ensmp.fr>) id 1ZHyvb-0005cw-Vx
 for pgsql-hackers@postgresql.org; Wed, 22 Jul 2015 18:39:45 +0000
Received: from cri.ensmp.fr
 (host162-162-static.42-85-b.business.telecomitalia.it [85.42.162.162])
 (authenticated bits=0)
 by boipeva.ensmp.fr (8.15.1/8.15.1/JMMC-22/Oct/2013) with ESMTPSA id
 t6MIdMMx004194
 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO);
 Wed, 22 Jul 2015 20:39:24 +0200
Date: Wed, 22 Jul 2015 20:39:22 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
X-X-Sender: fabien@sto
To: Josh Berkus <josh@agliodbs.com>
cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Subject: Re: pgbench stats per script & other stuff
In-Reply-To: <55AFD8C6.8010507@agliodbs.com>
Message-ID: <alpine.DEB.2.10.1507222024340.11465@sto>
References: <alpine.DEB.2.10.1507171544450.26125@sto>
 <CA+Tgmoa=ud6E=4afK3srNj_4j8Cckm4OD_=0=uxSD5JVwsO4rQ@mail.gmail.com>
 <alpine.DEB.2.10.1507211626000.30948@sto>
 <CA+TgmoYQi7sPG+b_19Y4bn2wUPUujsSZ_qOF8nWZTrC1Pbqivg@mail.gmail.com>
 <alpine.DEB.2.10.1507211819460.30948@sto>
 <WM!aa4cff4a48647dfeb51adbc23faaba1f82d825d5edc7fcfe10aa08a36243c5ffb656060d76dd428676a64e1e72c8a672!@asav-2.01.com>
 <55AEDDA4.8020009@agliodbs.com> <alpine.DEB.2.10.1507220706260.5636@sto>
 <WM!36f7f6aea11042e334dd8ddca8dd52df3de0913ec1f5bc42bfcc27f3eb60d576c8dac02c33f02b88abead156dfec3da0!@asav-2.01.com>
 <55AFD8C6.8010507@agliodbs.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Miltered: at boipeva.ensmp.fr with ID 55AFE35B.000 by Joe's j-chkmail (http
 : // j-chkmail dot ensmp dot fr)!
X-j-chkmail-Auth: USER-ID fabien.coelho
X-j-chkmail-Enveloppe: 55AFE35B.000 from
 host162-162-static.42-85-b.business.telecomitalia.it/host162-162-static.42-85-b.business.telecomitalia.it/85.42.162.162/cri.ensmp.fr/<coelho@cri.ensmp.fr>
X-Pg-Spam-Score: -3.1 (---)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


> If so, I would vote for:
>   -f script1.bench:3 -f script2.bench:1
> over:
>   -f script1.bench -w 3 -f script2.bench -w 1

Ok, I'll take that into consideration. Any other opinion out there? The 
current v3 version is:

   -w 3 -f script1.bench -w 1 -f script2.bench

With provision to generate errors if a -w is set but not used,
in two case.

  - in the middle ... -w 4 <no script option...> -w 1 ...
  - in the end ... -w 1 <no script option...>

I can provide -f x:weight easilly, but this mean that there will be no way 
to associate weight for internal scripts. Not orthogonal, not very 
elegant, but no big deal.

> Oh, you misunderstand.  "script1" and "script2" are meant to be 
> user-supplied names which then get reported in things like response time 
> output.  They're labels.

Ok, that is much better. This means that labels should not choose names 
which may interact with other commands, so maybe a list would have been 
nice as well. Anyway, I do not think it is the way to go just for this 
feature.

-- 
Fabien.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers