Date: Thu, 3 Sep 2015 11:36:02 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>, Josh Berkus <josh@agliodbs.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: pgbench stats per script & other stuff
In-Reply-To: <20150903091122.GA23957@awork2.anarazel.de>
Message-ID: <alpine.DEB.2.10.1509031127180.16877@sto>
References: <55AFD8C6.8010507@agliodbs.com>
 <CA+TgmobZSBmWzugAQp94=q98c2fmSBc+gRPwfNM+94dhjpL3tg@mail.gmail.com>
 <alpine.DEB.2.10.1507231759400.10585@sto>
 <CA+TgmoZEvNJ8wkVdHCsWnsz8Rz-MHebGp4DY+8WjiU-xYPT6Nw@mail.gmail.com>
 <alpine.DEB.2.10.1507250910540.20046@sto>
 <alpine.DEB.2.10.1507251618230.25082@sto>
 <alpine.DEB.2.10.1507281626330.3538@sto>
 <alpine.DEB.2.10.1507301801500.22793@sto>
 <20150902172617.GJ5286@alap3.anarazel.de>
 <alpine.DEB.2.10.1509022002110.21677@sto>
 <20150903091122.GA23957@awork2.anarazel.de>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


> Right now builtins and user defined scripts are stored in different data
> structures. I'd rather see them in the same.

They already are in the same array (sql_script) when pre-processed and 
executed, there is no distinction beyond initialization.

The builtin_script array contains the equivalent of the external custom 
file (name, lines of code), so that they can be processed by 
process_builtin and addScript to build the SQLScript ready for execution, 
while for external files it relies on process_file and addScript.

-- 
Fabien.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers