Date: Wed, 16 Dec 2015 11:33:09 +0100 (CET)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael.paquier@gmail.com>
cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: pgbench stats per script & other stuff
In-Reply-To: 
 <CAB7nPqRhA3OrpTpKP4saL5652F7xmoEOfT09th8e8TpRdv=KQA@mail.gmail.com>
Message-ID: <alpine.DEB.2.10.1512161124590.31973@sto>
References: <alpine.DEB.2.10.1507220706260.5636@sto>
 <WM!36f7f6aea11042e334dd8ddca8dd52df3de0913ec1f5bc42bfcc27f3eb60d576c8dac02c33f02b88abead156dfec3da0!@asav-2.01.com>
 <55AFD8C6.8010507@agliodbs.com>
 <CA+TgmobZSBmWzugAQp94=q98c2fmSBc+gRPwfNM+94dhjpL3tg@mail.gmail.com>
 <alpine.DEB.2.10.1507231759400.10585@sto>
 <CA+TgmoZEvNJ8wkVdHCsWnsz8Rz-MHebGp4DY+8WjiU-xYPT6Nw@mail.gmail.com>
 <alpine.DEB.2.10.1507250910540.20046@sto>
 <alpine.DEB.2.10.1507251618230.25082@sto>
 <alpine.DEB.2.10.1507281626330.3538@sto>
 <alpine.DEB.2.10.1507301801500.22793@sto>
 <20150902172617.GJ5286@alap3.anarazel.de>
 <alpine.DEB.2.10.1509030917480.16877@sto>
 <alpine.DEB.2.10.1509260923150.8351@sto>
 <alpine.DEB.2.10.1510030810440.24488@sto>
 <CAB7nPqQV0wHJ4CKw_0YFQbfVahQrw80QfaHRGQw7cgbux7mKCg@mail.gmail.com>
 <alpine.DEB.2.10.1512142131430.22108@sto>
 <CAB7nPqRhA3OrpTpKP4saL5652F7xmoEOfT09th8e8TpRdv=KQA@mail.gmail.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


>>> It seems also that it would be a good idea to split the patch into two
>>> parts:
>>> 1) Refactor the code so as the existing test scripts are put under the
>>> same umbrella with addScript, adding at the same time the new option
>>> -b.
>>> 2) Add the weight facility and its related statistics.
>>
>> Sigh. The patch & documentation are probably not independent, so that would
>> make two dependent patches, probably.
>
> I am not really saying so, it seems just that doing the refactoring
> (with its related docs), and then add the extension for the weight
> (with its docs) is more natural than doing both things at the same
> time.

Ok. I can separate the refactoring (scripts & stats) and the weight stuff 
on top of the refactoring.

-- 
Fabien.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers