Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aT2gu-0007WP-O7 for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Feb 2016 07:26:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aT2gt-0002bG-Sw for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Feb 2016 07:26:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aT2fX-00013X-Tk for pgsql-hackers@postgresql.org; Tue, 09 Feb 2016 07:25:03 +0000 Received: from boipeva.ensmp.fr ([194.214.158.136]) by magus.postgresql.org with esmtp (Exim 4.84) (envelope-from ) id 1aT2fS-00008J-UG for pgsql-hackers@postgresql.org; Tue, 09 Feb 2016 07:25:01 +0000 Received: from cri.ensmp.fr (wifi2-mpt-199.paris.ensmp.fr [192.168.153.199]) (authenticated bits=0) by boipeva.ensmp.fr (8.15.2/8.15.1/JMMC-22/Oct/2013) with ESMTPSA id u197OrmH005645 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 9 Feb 2016 08:24:56 +0100 Date: Tue, 9 Feb 2016 08:24:53 +0100 (CET) From: Fabien COELHO X-X-Sender: fabien@sto To: Michael Paquier cc: Alvaro Herrera , "pgsql-hackers@postgresql.org" Subject: Re: pgbench stats per script & other stuff In-Reply-To: Message-ID: References: <20160204095806.GA220429@alvherre.pgsql> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-Miltered: at boipeva.ensmp.fr with ID 56B99445.000 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)! X-j-chkmail-Auth: USER-ID fabien.coelho X-j-chkmail-Enveloppe: 56B99445.000 from wifi2-mpt-199.paris.ensmp.fr/wifi2-mpt-199.paris.ensmp.fr/192.168.153.199/cri.ensmp.fr/ X-Pg-Spam-Score: -2.2 (--) Content-Type: TEXT/PLAIN; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Hi Michaƫl, >> Attached 19-d and 19-e. > > +/* return builtin script "name", or fail if not found */ > builtin does not sound like correct English to me, but built-in is. I notice that "man bash" uses "builtin" extensively, so I think it is okay like that, but I would be fine as well with "built-in". I suggest to let it as is unless some native speaker really requires "built-in", in which case there would be many places to update, so that would be another orthographic-oriented patch:-) -- Fabien. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers