Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akRh4-000161-Dd for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Mar 2016 07:34:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1akRh3-000674-KD for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Mar 2016 07:34:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1akRfi-0004aq-BB for pgsql-hackers@postgresql.org; Mon, 28 Mar 2016 07:33:10 +0000 Received: from jiboia.ensmp.fr ([194.214.158.137]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akRfe-0007bq-Nv for pgsql-hackers@postgresql.org; Mon, 28 Mar 2016 07:33:09 +0000 Received: from cri.ensmp.fr (152.200.219.88.rev.sfr.net [88.219.200.152]) (authenticated bits=0) by jiboia.ensmp.fr (8.15.2/8.15.1/JMMC-22/Oct/2013) with ESMTPSA id u2S7X3qH013344 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 28 Mar 2016 09:33:04 +0200 Date: Mon, 28 Mar 2016 09:32:59 +0200 (CEST) From: Fabien COELHO X-X-Sender: fabien@sto To: Jeff Janes cc: PostgreSQL Developers Subject: Re: pgbench stats per script & other stuff In-Reply-To: Message-ID: References: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-1168642795-1459150381=:16239" X-Miltered: at jiboia.ensmp.fr with ID 56F8DE2F.000 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)! X-j-chkmail-Auth: USER-ID fabien.coelho X-j-chkmail-Enveloppe: 56F8DE2F.000 from 152.200.219.88.rev.sfr.net/152.200.219.88.rev.sfr.net/88.219.200.152/cri.ensmp.fr/ X-Pg-Spam-Score: -2.9 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1168642795-1459150381=:16239 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed > - that it does work:-) I'm not sure what happens by the script selection > process, it should be checked carefully because it was not designed > with allowing a zero weight, and it may depend on its/their positions. > It may already work, but it really needs checking. Hmmm, it seems ok. Attached is an updated patch, which: > - I would suggest that a warning is shown when a weight is zero, > something like "warning, script #%d weight is zero, will be ignored". includes such a warning. > - the documentation should be updated:-) adds a line about 0 weight in the documentation. -- Fabien. --8323329-1168642795-1459150381=:16239 Content-Type: TEXT/x-diff; name=pgbench-zero-weight-2.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=pgbench-zero-weight-2.patch ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvcGdiZW5jaC5zZ21sIGIv ZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNoLnNnbWwNCmluZGV4IGM2ZDE0NTQu LmUzMWQ1ZWUgMTAwNjQ0DQotLS0gYS9kb2Mvc3JjL3NnbWwvcmVmL3BnYmVu Y2guc2dtbA0KKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNoLnNnbWwN CkBAIC02OTgsNiArNjk4LDcgQEAgcGdiZW5jaCA8b3B0aW9uYWw+IDxyZXBs YWNlYWJsZT5vcHRpb25zPC8+IDwvb3B0aW9uYWw+IDxyZXBsYWNlYWJsZT5k Ym5hbWU8Lz4NCiAgICBFYWNoIHNjcmlwdCBtYXkgYmUgZ2l2ZW4gYSByZWxh dGl2ZSB3ZWlnaHQgc3BlY2lmaWVkIGFmdGVyIGENCiAgICA8bGl0ZXJhbD5A PC8+IHNvIGFzIHRvIGNoYW5nZSBpdHMgZHJhd2luZyBwcm9iYWJpbGl0eS4N CiAgICBUaGUgZGVmYXVsdCB3ZWlnaHQgaXMgPGxpdGVyYWw+MTwvPi4NCisg ICBXZWlnaHQgPGxpdGVyYWw+MDwvPiBzY3JpcHRzIGFyZSBpZ25vcmVkLg0K ICA8L3BhcmE+DQogDQogICA8cGFyYT4NCmRpZmYgLS1naXQgYS9zcmMvYmlu L3BnYmVuY2gvcGdiZW5jaC5jIGIvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2gu Yw0KaW5kZXggNDE5NmIwZS4uMGMxYTBlZSAxMDA2NDQNCi0tLSBhL3NyYy9i aW4vcGdiZW5jaC9wZ2JlbmNoLmMNCisrKyBiL3NyYy9iaW4vcGdiZW5jaC9w Z2JlbmNoLmMNCkBAIC0yOTUzLDEwICsyOTUzLDEwIEBAIHBhcnNlU2NyaXB0 V2VpZ2h0KGNvbnN0IGNoYXIgKm9wdGlvbiwgY2hhciAqKnNjcmlwdCkNCiAJ CQlmcHJpbnRmKHN0ZGVyciwgImludmFsaWQgd2VpZ2h0IHNwZWNpZmljYXRp b246ICVzXG4iLCBzZXApOw0KIAkJCWV4aXQoMSk7DQogCQl9DQotCQlpZiAo d3RtcCA+IElOVF9NQVggfHwgd3RtcCA8PSAwKQ0KKwkJaWYgKHd0bXAgPiBJ TlRfTUFYIHx8IHd0bXAgPCAwKQ0KIAkJew0KIAkJCWZwcmludGYoc3RkZXJy LA0KLQkJCSJ3ZWlnaHQgc3BlY2lmaWNhdGlvbiBvdXQgb2YgcmFuZ2UgKDEg Li4gJXUpOiAiIElOVDY0X0ZPUk1BVCAiXG4iLA0KKwkJCSJ3ZWlnaHQgc3Bl Y2lmaWNhdGlvbiBvdXQgb2YgcmFuZ2UgKDAgLi4gJXUpOiAiIElOVDY0X0ZP Uk1BVCAiXG4iLA0KIAkJCQkJSU5UX01BWCwgKGludDY0KSB3dG1wKTsNCiAJ CQlleGl0KDEpOw0KIAkJfQ0KQEAgLTI5ODcsNiArMjk4NywxMyBAQCBhZGRT Y3JpcHQoUGFyc2VkU2NyaXB0IHNjcmlwdCkNCiAJCWV4aXQoMSk7DQogCX0N CiANCisJaWYgKHNjcmlwdC53ZWlnaHQgPT0gMCkNCisJew0KKwkJZnByaW50 ZihzdGRlcnIsDQorCQkJCSJ3YXJuaW5nLCBzY3JpcHQgXCIlc1wiICglZCkg d2VpZ2h0IGlzIHplcm8sIHdpbGwgYmUgaWdub3JlZFxuIiwNCisJCQkJc2Ny aXB0LmRlc2MsIG51bV9zY3JpcHRzKTsNCisJfQ0KKw0KIAlzcWxfc2NyaXB0 W251bV9zY3JpcHRzXSA9IHNjcmlwdDsNCiAJbnVtX3NjcmlwdHMrKzsNCiB9 DQpAQCAtMzUyNyw2ICszNTM0LDEyIEBAIG1haW4oaW50IGFyZ2MsIGNoYXIg Kiphcmd2KQ0KIAkJLyogY2Fubm90IG92ZXJmbG93OiB3ZWlnaHQgaXMgMzJi LCB0b3RhbF93ZWlnaHQgNjRiICovDQogCQl0b3RhbF93ZWlnaHQgKz0gc3Fs X3NjcmlwdFtpXS53ZWlnaHQ7DQogDQorCWlmICh0b3RhbF93ZWlnaHQgPT0g MCkNCisJew0KKwkJZnByaW50ZihzdGRlcnIsICJ0b3RhbCB3ZWlnaHQgZm9y IHNjcmlwdHMgKC1iIGFuZCAtZiBvcHRpb25zKSBjYW5ub3QgYmUgemVyb1xu Iik7DQorCQlleGl0KDEpOw0KKwl9DQorDQogCS8qIHNob3cgcGVyIHNjcmlw dCBzdGF0cyBpZiBzZXZlcmFsIHNjcmlwdHMgYXJlIHVzZWQgKi8NCiAJaWYg KG51bV9zY3JpcHRzID4gMSkNCiAJCXBlcl9zY3JpcHRfc3RhdHMgPSB0cnVl Ow0K --8323329-1168642795-1459150381=:16239 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --8323329-1168642795-1459150381=:16239--