Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akz9q-00062E-Tm for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Mar 2016 19:18:31 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1akz9q-0000G5-Bq for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Mar 2016 19:18:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1akz9o-0000Ej-EE for pgsql-hackers@postgresql.org; Tue, 29 Mar 2016 19:18:28 +0000 Received: from boipeva.ensmp.fr ([194.214.158.136]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akz9l-0002H4-5d for pgsql-hackers@postgresql.org; Tue, 29 Mar 2016 19:18:27 +0000 Received: from cri.ensmp.fr (152.200.219.88.rev.sfr.net [88.219.200.152]) (authenticated bits=0) by boipeva.ensmp.fr (8.15.2/8.15.1/JMMC-22/Oct/2013) with ESMTPSA id u2TJIMhn001862 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 29 Mar 2016 21:18:23 +0200 Date: Tue, 29 Mar 2016 21:18:21 +0200 (CEST) From: Fabien COELHO X-X-Sender: fabien@sto To: Alvaro Herrera cc: PostgreSQL Developers Subject: Re: pgbench stats per script & other stuff In-Reply-To: <20160329175817.GA883652@alvherre.pgsql> Message-ID: References: <20160329175817.GA883652@alvherre.pgsql> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-1149023719-1459279102=:5677" X-Miltered: at boipeva.ensmp.fr with ID 56FAD4FE.000 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)! X-j-chkmail-Auth: USER-ID fabien.coelho X-j-chkmail-Enveloppe: 56FAD4FE.000 from 152.200.219.88.rev.sfr.net/152.200.219.88.rev.sfr.net/88.219.200.152/cri.ensmp.fr/ X-Pg-Spam-Score: -2.9 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1149023719-1459279102=:5677 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Hello, >> In doing this, I noticed that the latency output is wrong if you use -T >> instead of -t; it always says the latency is zero because "duration" is >> zero. I suppose it should be like in the attached instead. Indeed, I clearly overlooked option -t (transactions) which I never use. > Patch actually attached here. Tested. There is a small issue because the \n is missing. Here is another version which just replaces duration by time_include, as they should be pretty close, and fixes the style so that it is the same whether the detailed stats are collected or not, as you pointed out. >> At the same time, it says "latency average: XYZ" instead of "latency >> average = XYZ" as in printSimpleStats, which doesn't look terribly >> important. But the line appears in the SGML docs. Indeed. The documentation is manually edited when submitting changes so as to minimize diffs, but then it does not correspond anymore to any actual output, so it is easy to do it wrong. -- Fabien. --8323329-1149023719-1459279102=:5677 Content-Type: TEXT/x-diff; name=pgbench-latency-2.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=pgbench-latency-2.patch ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvcGdiZW5jaC5zZ21sIGIv ZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNoLnNnbWwNCmluZGV4IDA2Y2Q1ZGIu LjI5N2FmNGYgMTAwNjQ0DQotLS0gYS9kb2Mvc3JjL3NnbWwvcmVmL3BnYmVu Y2guc2dtbA0KKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNoLnNnbWwN CkBAIC0xMjUzLDggKzEyNTMsOCBAQCBudW1iZXIgb2YgY2xpZW50czogMTAN CiBudW1iZXIgb2YgdGhyZWFkczogMQ0KIG51bWJlciBvZiB0cmFuc2FjdGlv bnMgcGVyIGNsaWVudDogMTAwMA0KIG51bWJlciBvZiB0cmFuc2FjdGlvbnMg YWN0dWFsbHkgcHJvY2Vzc2VkOiAxMDAwMC8xMDAwMA0KLWxhdGVuY3kgYXZl cmFnZSA9IDE1Ljg0NCBtcw0KLWxhdGVuY3kgc3RkZGV2ID0gMi43MTUgbXMN CitsYXRlbmN5IGF2ZXJhZ2U6IDE1Ljg0NCBtcw0KK2xhdGVuY3kgc3RkZGV2 OiAyLjcxNSBtcw0KIHRwcyA9IDYxOC43NjQ1NTUgKGluY2x1ZGluZyBjb25u ZWN0aW9ucyBlc3RhYmxpc2hpbmcpDQogdHBzID0gNjIyLjk3NzY5OCAoZXhj bHVkaW5nIGNvbm5lY3Rpb25zIGVzdGFibGlzaGluZykNCiBzY3JpcHQgc3Rh dGlzdGljczoNCmRpZmYgLS1naXQgYS9zcmMvYmluL3BnYmVuY2gvcGdiZW5j aC5jIGIvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYw0KaW5kZXggNTJkMTIy My4uZDUzODBkMiAxMDA2NDQNCi0tLSBhL3NyYy9iaW4vcGdiZW5jaC9wZ2Jl bmNoLmMNCisrKyBiL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmMNCkBAIC0z MDk5LDggKzMwOTksOCBAQCBwcmludFNpbXBsZVN0YXRzKGNoYXIgKnByZWZp eCwgU2ltcGxlU3RhdHMgKnNzKQ0KIAlkb3VibGUJCWxhdGVuY3kgPSBzcy0+ c3VtIC8gc3MtPmNvdW50Ow0KIAlkb3VibGUJCXN0ZGRldiA9IHNxcnQoc3Mt PnN1bTIgLyBzcy0+Y291bnQgLSBsYXRlbmN5ICogbGF0ZW5jeSk7DQogDQot CXByaW50ZigiJXMgYXZlcmFnZSA9ICUuM2YgbXNcbiIsIHByZWZpeCwgMC4w MDEgKiBsYXRlbmN5KTsNCi0JcHJpbnRmKCIlcyBzdGRkZXYgPSAlLjNmIG1z XG4iLCBwcmVmaXgsIDAuMDAxICogc3RkZGV2KTsNCisJcHJpbnRmKCIlcyBh dmVyYWdlOiAlLjNmIG1zXG4iLCBwcmVmaXgsIDAuMDAxICogbGF0ZW5jeSk7 DQorCXByaW50ZigiJXMgc3RkZGV2OiAlLjNmIG1zXG4iLCBwcmVmaXgsIDAu MDAxICogc3RkZGV2KTsNCiB9DQogDQogLyogcHJpbnQgb3V0IHJlc3VsdHMg Ki8NCkBAIC0zMTU1LDcgKzMxNTUsNyBAQCBwcmludFJlc3VsdHMoVFN0YXRl ICp0aHJlYWRzLCBTdGF0c0RhdGEgKnRvdGFsLCBpbnN0cl90aW1lIHRvdGFs X3RpbWUsDQogCWVsc2UNCiAJCS8qIG9ubHkgYW4gYXZlcmFnZSBsYXRlbmN5 IGNvbXB1dGVkIGZyb20gdGhlIGR1cmF0aW9uIGlzIGF2YWlsYWJsZSAqLw0K IAkJcHJpbnRmKCJsYXRlbmN5IGF2ZXJhZ2U6ICUuM2YgbXNcbiIsDQotCQkJ ICAgMTAwMC4wICogZHVyYXRpb24gKiBuY2xpZW50cyAvIHRvdGFsLT5jbnQp Ow0KKwkJCSAgIDEwMDAuMCAqIHRpbWVfaW5jbHVkZSAqIG5jbGllbnRzIC8g dG90YWwtPmNudCk7DQogDQogCWlmICh0aHJvdHRsZV9kZWxheSkNCiAJew0K --8323329-1149023719-1459279102=:5677 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --8323329-1149023719-1459279102=:5677--