Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNFjK-0007Th-QS for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 08:41:18 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bNFjK-0002Zt-DW for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 08:41:18 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bNFhr-0000oo-KV for pgsql-hackers@postgresql.org; Wed, 13 Jul 2016 08:39:47 +0000 Received: from jiboia.ensmp.fr ([194.214.158.137]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNFhh-0008JH-MV for pgsql-hackers@postgresql.org; Wed, 13 Jul 2016 08:39:45 +0000 Received: from cri.ensmp.fr (AGrenoble-653-1-69-83.w92-129.abo.wanadoo.fr [92.129.7.83]) (authenticated bits=0) by jiboia.ensmp.fr (8.15.2/8.15.1/JMMC-22/Oct/2013) with ESMTPSA id u6D8dYxO005496 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 13 Jul 2016 10:39:35 +0200 Date: Wed, 13 Jul 2016 10:39:34 +0200 (CEST) From: Fabien COELHO X-X-Sender: fabien@sto To: Peter Eisentraut cc: PostgreSQL Developers Subject: Re: pgbench - compute & show latency consistently In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-32068755-1468399175=:7486" X-Miltered: at jiboia.ensmp.fr with ID 5785FE46.000 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)! X-j-chkmail-Auth: USER-ID fabien.coelho X-j-chkmail-Enveloppe: 5785FE46.000 from AGrenoble-653-1-69-83.w92-129.abo.wanadoo.fr/AGrenoble-653-1-69-83.w92-129.abo.wanadoo.fr/92.129.7.83/cri.ensmp.fr/ X-Pg-Spam-Score: -3.2 (---) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-32068755-1468399175=:7486 Content-Type: text/plain; format=flowed; charset=US-ASCII Hello Peter, >> number of transactions per client: 1000 >> -latency average = 15.844 ms >> +latency average: 15.844 ms >> tps = 618.764555 (including connections establishing) > > I think what you have here is that colons separate input parameters and > equal signs separate result output. So I think it's OK the way it is. Hmmm... Then other measures displayed are not all consistent with this theory. Also there is still the bug under -t which displays a 0 latency. The attached patch still fixes that and make it consistent the other way around, i.e. by using "=" for latency. I switched to use ":" for weight which is an input parameter. I let ":" when there is a long sentence to describe the figure displayed, more on aesthetical grounds. > Maybe a better improvement would be introducing section headings like > "test parameters" and "test results". This would add more lines to the report, to sure how desirable it is. -- Fabien. --8323329-32068755-1468399175=:7486 Content-Type: text/x-diff; name=pgbench-latency-t-2.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=pgbench-latency-t-2.patch ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmMgYi9zcmMv YmluL3BnYmVuY2gvcGdiZW5jaC5jDQppbmRleCA4N2ZiMDA2Li5hZjExNjlh IDEwMDY0NA0KLS0tIGEvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYw0KKysr IGIvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYw0KQEAgLTMyOTEsOSArMzI5 MSw5IEBAIHByaW50UmVzdWx0cyhUU3RhdGUgKnRocmVhZHMsIFN0YXRzRGF0 YSAqdG90YWwsIGluc3RyX3RpbWUgdG90YWxfdGltZSwNCiAJaWYgKHRocm90 dGxlX2RlbGF5IHx8IHByb2dyZXNzIHx8IGxhdGVuY3lfbGltaXQpDQogCQlw cmludFNpbXBsZVN0YXRzKCJsYXRlbmN5IiwgJnRvdGFsLT5sYXRlbmN5KTsN CiAJZWxzZQ0KLQkJLyogb25seSBhbiBhdmVyYWdlIGxhdGVuY3kgY29tcHV0 ZWQgZnJvbSB0aGUgZHVyYXRpb24gaXMgYXZhaWxhYmxlICovDQotCQlwcmlu dGYoImxhdGVuY3kgYXZlcmFnZTogJS4zZiBtc1xuIiwNCi0JCQkgICAxMDAw LjAgKiBkdXJhdGlvbiAqIG5jbGllbnRzIC8gdG90YWwtPmNudCk7DQorCQkv KiBubyBtZWFzdXJlLCBzaG93IGF2ZXJhZ2UgbGF0ZW5jeSBjb21wdXRlZCBm cm9tIHJ1biB0aW1lICovDQorCQlwcmludGYoImxhdGVuY3kgYXZlcmFnZSA9 ICUuM2YgbXNcbiIsDQorCQkJICAgMTAwMC4wICogdGltZV9pbmNsdWRlICog bmNsaWVudHMgLyB0b3RhbC0+Y250KTsNCiANCiAJaWYgKHRocm90dGxlX2Rl bGF5KQ0KIAl7DQpAQCAtMzMxOSw3ICszMzE5LDcgQEAgcHJpbnRSZXN1bHRz KFRTdGF0ZSAqdGhyZWFkcywgU3RhdHNEYXRhICp0b3RhbCwgaW5zdHJfdGlt ZSB0b3RhbF90aW1lLA0KIAkJew0KIAkJCWlmIChudW1fc2NyaXB0cyA+IDEp DQogCQkJCXByaW50ZigiU1FMIHNjcmlwdCAlZDogJXNcbiINCi0JCQkJCSAg ICIgLSB3ZWlnaHQgPSAlZCAodGFyZ2V0cyAlLjFmJSUgb2YgdG90YWwpXG4i DQorCQkJCQkgICAiIC0gd2VpZ2h0OiAlZCAodGFyZ2V0cyAlLjFmJSUgb2Yg dG90YWwpXG4iDQogCQkJCQkgICAiIC0gIiBJTlQ2NF9GT1JNQVQgIiB0cmFu c2FjdGlvbnMgKCUuMWYlJSBvZiB0b3RhbCwgdHBzID0gJWYpXG4iLA0KIAkJ CQkJICAgaSArIDEsIHNxbF9zY3JpcHRbaV0uZGVzYywNCiAJCQkJCSAgIHNx bF9zY3JpcHRbaV0ud2VpZ2h0LA0K --8323329-32068755-1468399175=:7486 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --8323329-32068755-1468399175=:7486--