Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d04OX-0005qH-6L for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Apr 2017 11:00:33 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d04OW-0003RT-FM for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Apr 2017 11:00:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d04OV-0003RJ-MG for pgsql-hackers@postgresql.org; Mon, 17 Apr 2017 11:00:31 +0000 Received: from boipeva.ensmp.fr ([194.214.158.136] helo=cc-tupan-roaming-b.ensmp.fr) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d04ON-00058i-FT for pgsql-hackers@postgresql.org; Mon, 17 Apr 2017 11:00:30 +0000 Received: from cri.ensmp.fr (KYNcd-02p12-193.ppp11.odn.ad.jp [61.123.60.193]) (authenticated bits=0) by cc-tupan-roaming-b.ensmp.fr (8.15.2/8.15.2/JMMC-22/Oct/2013) with ESMTPSA id v3HB08Gu025761 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 17 Apr 2017 13:00:15 +0200 Date: Mon, 17 Apr 2017 20:00:07 +0900 (JST) From: Fabien COELHO X-X-Sender: fabien@lancre To: Tatsuo Ishii cc: tgl@sss.pgh.pa.us, rafia.sabih@enterprisedb.com, michael.paquier@gmail.com, Langote_Amit_f8@lab.ntt.co.jp, robertmhaas@gmail.com, pavel.stehule@gmail.com, PostgreSQL Developers Subject: Re: pgbench - allow to store select results into variables In-Reply-To: <20170417.181123.1539611157606514675.t-ishii@sraoss.co.jp> Message-ID: References: <20170410.083219.1414201047665260666.t-ishii@sraoss.co.jp> <20170417.181123.1539611157606514675.t-ishii@sraoss.co.jp> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-767265424-1492426817=:1741" X-Miltered: at cc-tupan-roaming-b.ensmp.fr with ID 58F4A038.001 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)! X-j-chkmail-Auth: USER-ID fabien.coelho X-j-chkmail-Enveloppe: 58F4A038.001 from KYNcd-02p12-193.ppp11.odn.ad.jp/KYNcd-02p12-193.ppp11.odn.ad.jp/61.123.60.193/cri.ensmp.fr/ X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-767265424-1492426817=:1741 Content-Type: text/plain; charset=US-ASCII; format=flowed Hello, > I think you'd better to change the following comments because there's > no psqlscan.l or psqlscanslash.l in pgbench source tree. > > + * underscore. Keep this in sync with the definition of variable_char in > + * psqlscan.l and psqlscanslash.l. Here is a v3 with a more precise comment. -- Fabien. --8323329-767265424-1492426817=:1741 Content-Type: text/x-diff; name=pgbench-utf8-vars-3.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=pgbench-utf8-vars-3.patch ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvcGdiZW5jaC5zZ21sIGIv ZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNoLnNnbWwNCmluZGV4IDFlZWU4ZGMu LjUwMmQzMWIgMTAwNjQ0DQotLS0gYS9kb2Mvc3JjL3NnbWwvcmVmL3BnYmVu Y2guc2dtbA0KKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNoLnNnbWwN CkBAIC04MjUsNiArODI1LDggQEAgcGdiZW5jaCA8b3B0aW9uYWw+IDxyZXBs YWNlYWJsZT5vcHRpb25zPC8+IDwvb3B0aW9uYWw+IDxyZXBsYWNlYWJsZT5k Ym5hbWU8Lz4NCiAgICAgIDxwYXJhPg0KICAgICAgIFNldHMgdmFyaWFibGUg PHJlcGxhY2VhYmxlPnZhcm5hbWU8Lz4gdG8gYSB2YWx1ZSBjYWxjdWxhdGVk DQogICAgICAgZnJvbSA8cmVwbGFjZWFibGU+ZXhwcmVzc2lvbjwvPi4NCisg ICAgICBUaGUgdmFyaWFibGUgbmFtZSBtdXN0IGNvbnNpc3Qgb2YgbGV0dGVy cyAoaW5jbHVkaW5nIG5vbi1MYXRpbiBsZXR0ZXJzKSwNCisgICAgICBkaWdp dHMsIGFuZCB1bmRlcnNjb3Jlcy4NCiAgICAgICBUaGUgZXhwcmVzc2lvbiBt YXkgY29udGFpbiBpbnRlZ2VyIGNvbnN0YW50cyBzdWNoIGFzIDxsaXRlcmFs PjU0MzI8Lz4sDQogICAgICAgZG91YmxlIGNvbnN0YW50cyBzdWNoIGFzIDxs aXRlcmFsPjMuMTQxNTk8Lz4sDQogICAgICAgcmVmZXJlbmNlcyB0byB2YXJp YWJsZXMgPGxpdGVyYWw+OjwvPjxyZXBsYWNlYWJsZT52YXJpYWJsZW5hbWU8 Lz4sDQpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9wZ2JlbmNoL2V4cHJzY2FuLmwg Yi9zcmMvYmluL3BnYmVuY2gvZXhwcnNjYW4ubA0KaW5kZXggZGMxMzY3Yi4u MTg2MmZlNCAxMDA2NDQNCi0tLSBhL3NyYy9iaW4vcGdiZW5jaC9leHByc2Nh bi5sDQorKysgYi9zcmMvYmluL3BnYmVuY2gvZXhwcnNjYW4ubA0KQEAgLTU4 LDkgKzU4LDkgQEAgZXh0ZXJuIHZvaWQgZXhwcl95eXNldF9jb2x1bW4oaW50 IGNvbHVtbl9ubywgeXlzY2FuX3QgeXlzY2FubmVyKTsNCiAlb3B0aW9uIHBy ZWZpeD0iZXhwcl95eSINCiANCiAvKiBDaGFyYWN0ZXIgY2xhc3NlcyAqLw0K LWFscGhhCQkJW2EtekEtWl9dDQorYWxwaGEJCQlbYS16QS1aXDIwMC1cMzc3 X10NCiBkaWdpdAkJCVswLTldDQotYWxudW0JCQlbYS16QS1aMC05X10NCith bG51bQkJCVtBLVphLXpcMjAwLVwzNzdfMC05XQ0KIC8qIHtzcGFjZX0gKyB7 bm9uc3BhY2V9ICsge25ld2xpbmV9IHNob3VsZCBjb3ZlciBhbGwgY2hhcmFj dGVycyAqLw0KIHNwYWNlCQkJWyBcdFxyXGZcdl0NCiBub25zcGFjZQkJW14g XHRcclxmXHZcbl0NCmRpZmYgLS1naXQgYS9zcmMvYmluL3BnYmVuY2gvcGdi ZW5jaC5jIGIvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYw0KaW5kZXggYWUz NjI0Ny4uNDRhZTI5ZSAxMDA2NDQNCi0tLSBhL3NyYy9iaW4vcGdiZW5jaC9w Z2JlbmNoLmMNCisrKyBiL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmMNCkBA IC0xMDIwLDE5ICsxMDIwLDM4IEBAIG1ha2VWYXJpYWJsZU51bWVyaWMoVmFy aWFibGUgKnZhcikNCiAJcmV0dXJuIHRydWU7DQogfQ0KIA0KLS8qIGNoZWNr IHdoZXRoZXIgdGhlIG5hbWUgY29uc2lzdHMgb2YgYWxwaGFiZXRzLCBudW1l cmFscyBhbmQgdW5kZXJzY29yZXMuICovDQorLyoNCisgKiBDaGVjayB3aGV0 aGVyIGEgdmFyaWFibGUncyBuYW1lIGlzIGFsbG93ZWQuDQorICoNCisgKiBX ZSBhbGxvdyBhbnkgbm9uLUFTQ0lJIGNoYXJhY3RlciwgYXMgd2VsbCBhcyBB U0NJSSBsZXR0ZXJzLCBkaWdpdHMsIGFuZA0KKyAqIHVuZGVyc2NvcmUuDQor ICoNCisgKiBLZWVwIHRoaXMgaW4gc3luYyB3aXRoIHRoZSBkZWZpbml0aW9u cyBvZiB2YXJpYWJsZSBuYW1lIGNoYXJhY3RlcnMgaW4NCisgKiAic3JjL2Zl X3V0aWxzL3BzcWxzY2FuLmwiLCAic3JjL2Jpbi9wc3FsL3BzcWxzY2Fuc2xh c2gubCIgYW5kDQorICogInNyYy9iaW4vcGdiZW5jaC9leHByc2Nhbi5sIi4N CisgKg0KKyAqIE5vdGU6IHRoaXMgc3RhdGljIGZ1bmN0aW9uIGlzIGNvcGll ZCBmcm9tICJzcmMvYmluL3BzcWwvdmFyaWFibGVzLmMiDQorICovDQogc3Rh dGljIGJvb2wNCi1pc0xlZ2FsVmFyaWFibGVOYW1lKGNvbnN0IGNoYXIgKm5h bWUpDQordmFsaWRfdmFyaWFibGVfbmFtZShjb25zdCBjaGFyICpuYW1lKQ0K IHsNCi0JaW50CQkJaTsNCisJY29uc3QgdW5zaWduZWQgY2hhciAqcHRyID0g KGNvbnN0IHVuc2lnbmVkIGNoYXIgKikgbmFtZTsNCiANCi0JZm9yIChpID0g MDsgbmFtZVtpXSAhPSAnXDAnOyBpKyspDQorCS8qIE11c3RuJ3QgYmUgemVy by1sZW5ndGggKi8NCisJaWYgKCpwdHIgPT0gJ1wwJykNCisJCXJldHVybiBm YWxzZTsNCisNCisJd2hpbGUgKCpwdHIpDQogCXsNCi0JCWlmICghaXNhbG51 bSgodW5zaWduZWQgY2hhcikgbmFtZVtpXSkgJiYgbmFtZVtpXSAhPSAnXycp DQorCQlpZiAoSVNfSElHSEJJVF9TRVQoKnB0cikgfHwNCisJCQlzdHJjaHIo IkFCQ0RFRkdISUpLTE1OT1BRUlNUVVZXWFlaIiAiYWJjZGVmZ2hpamtsbW5v cHFyc3R1dnd4eXoiDQorCQkJCSAgICJfMDEyMzQ1Njc4OSIsICpwdHIpICE9 IE5VTEwpDQorCQkJcHRyKys7DQorCQllbHNlDQogCQkJcmV0dXJuIGZhbHNl Ow0KIAl9DQogDQotCXJldHVybiAoaSA+IDApOwkJCQkvKiBtdXN0IGJlIG5v bi1lbXB0eSAqLw0KKwlyZXR1cm4gdHJ1ZTsNCiB9DQogDQogLyoNCkBAIC0x MDU0LDcgKzEwNzMsNyBAQCBsb29rdXBDcmVhdGVWYXJpYWJsZShDU3RhdGUg KnN0LCBjb25zdCBjaGFyICpjb250ZXh0LCBjaGFyICpuYW1lKQ0KIAkJICog Q2hlY2sgZm9yIHRoZSBuYW1lIG9ubHkgd2hlbiBkZWNsYXJpbmcgYSBuZXcg dmFyaWFibGUgdG8gYXZvaWQNCiAJCSAqIG92ZXJoZWFkLg0KIAkJICovDQot CQlpZiAoIWlzTGVnYWxWYXJpYWJsZU5hbWUobmFtZSkpDQorCQlpZiAoIXZh bGlkX3ZhcmlhYmxlX25hbWUobmFtZSkpDQogCQl7DQogCQkJZnByaW50Zihz dGRlcnIsICIlczogaW52YWxpZCB2YXJpYWJsZSBuYW1lOiBcIiVzXCJcbiIs DQogCQkJCQljb250ZXh0LCBuYW1lKTsNCkBAIC0xMTQ4LDcgKzExNjcsNyBA QCBwYXJzZVZhcmlhYmxlKGNvbnN0IGNoYXIgKnNxbCwgaW50ICplYXRlbikN CiAJZG8NCiAJew0KIAkJaSsrOw0KLQl9IHdoaWxlIChpc2FsbnVtKCh1bnNp Z25lZCBjaGFyKSBzcWxbaV0pIHx8IHNxbFtpXSA9PSAnXycpOw0KKwl9IHdo aWxlIChJU19ISUdIQklUX1NFVChzcWxbaV0pIHx8IGlzYWxudW0oKHVuc2ln bmVkIGNoYXIpIHNxbFtpXSkgfHwgc3FsW2ldID09ICdfJyk7DQogCWlmIChp ID09IDEpDQogCQlyZXR1cm4gTlVMTDsNCiANCg== --8323329-767265424-1492426817=:1741 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --8323329-767265424-1492426817=:1741--