Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1efi2q-0005jl-Lu
	for pgsql-hackers@arkaria.postgresql.org; Sun, 28 Jan 2018 08:10:32 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1efi2o-0005EG-BS
	for pgsql-hackers@arkaria.postgresql.org; Sun, 28 Jan 2018 08:10:30 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <coelho@cri.ensmp.fr>)
	id 1efi2n-0005E6-T3
	for pgsql-hackers@lists.postgresql.org; Sun, 28 Jan 2018 08:10:30 +0000
Received: from smtp-3.mines-paristech.fr ([194.214.158.139]
 helo=cascavel.ensmp.fr)
	by makus.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <coelho@cri.ensmp.fr>)
	id 1efi2g-0002uz-1U
	for pgsql-hackers@postgresql.org; Sun, 28 Jan 2018 08:10:27 +0000
Received: from cri.ensmp.fr (234.237.219.88.rev.sfr.net [88.219.237.234])
	(authenticated bits=0)
	by cascavel.ensmp.fr (8.15.2/8.15.2/JMMC-22/Oct/2013) with ESMTPSA id
 w0S8ADCY008679
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
	Sun, 28 Jan 2018 09:10:14 +0100
Date: Sun, 28 Jan 2018 09:10:11 +0100 (CET)
From: Fabien COELHO <coelho@cri.ensmp.fr>
X-X-Sender: fabien@lancre
To: Ildar Musin <i.musin@postgrespro.ru>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: General purpose hashing func in pgbench
In-Reply-To: <12986cad-3dd9-a449-e318-4acd8a8e1697@postgrespro.ru>
Message-ID: <alpine.DEB.2.20.1801280851260.17596@lancre>
References: <0e8bd39e-dfcd-2879-f88f-272799ad7ef2@postgrespro.ru>
 <38f1503e-7b63-4612-24a9-041af25bb022@postgrespro.ru>
 <alpine.DEB.2.20.1712251506160.22976@lancre>
 <af1ccd41-dcd0-f56b-0a05-a558da54762b@postgrespro.ru>
 <alpine.DEB.2.20.1712251702170.22976@lancre>
 <9603bac9-ae5d-36c5-5978-a88bdb700e37@postgrespro.ru>
 <alpine.DEB.2.20.1801092000230.2326@hendaye>
 <63f5a6ac-0c5b-8d59-ca8b-fc8e11244a66@postgrespro.ru>
 <alpine.DEB.2.20.1801101903150.15856@lancre>
 <291822a3-0b3a-0b21-c694-c10776f516ac@postgrespro.ru>
 <6e47c84a-d42a-0e08-1b0d-33e6a6c87778@postgrespro.ru>
 <alpine.DEB.2.20.1801121614470.13422@lancre>
 <bca39e87-6d40-98f6-e4ef-e2d88e109f9c@postgrespro.ru>
 <alpine.DEB.2.20.1801170727240.11884@lancre>
 <960a8096-dde5-5175-7d7c-ef151086cbee@postgrespro.ru>
 <alpine.DEB.2.20.1801180710400.11884@lancre>
 <ae0c93b1-f8a8-a9aa-244c-0c872fa789f0@postgrespro.ru>
 <alpine.DEB.2.20.1801260714070.26762@lancre>
 <12986cad-3dd9-a449-e318-4acd8a8e1697@postgrespro.ru>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-ID: <alpine.DEB.2.20.1801280858241.17596@lancre>
X-Miltered: at cascavel.ensmp.fr with ID 5A6D8565.000 by Joe's j-chkmail (http
 : // j-chkmail dot ensmp dot fr)!
X-j-chkmail-Auth: USER-ID coelho
X-j-chkmail-Enveloppe: 5A6D8565.000 from
 234.237.219.88.rev.sfr.net/234.237.219.88.rev.sfr.net/88.219.237.234/cri.ensmp.fr/<coelho@cri.ensmp.fr>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk


Hello Ildar,

> I did everything you mention here and attached a new version on the patch.

Patch applies, compiles, runs ok.

Alas, I still have a few more very minor comments about the doc, sorry 
again:

   +       <entry> <literal>default_seed</literal> </entry>
   +       <entry>random seed used in hash functions by default</entry>

s/random //: the seed may or may not be random.

The "In some cases several distinct distributions..." paragraph is also 
just one line in the xml source file. It should be justified at about 80 
columns like others.

-- 
Fabien.