Date: Mon, 29 Jan 2018 09:58:59 +0100 (CET)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: "Rady, Doug" <radydoug@amazon.com>
cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Robert Haas <robertmhaas@gmail.com>
Subject: Re: PATCH: pgbench - option to build using ppoll() for larger
 connection counts
In-Reply-To: <654A1247-8E1E-4E9C-937D-9119B1731FF2@amazon.com>
Message-ID: <alpine.DEB.2.20.1801290953280.31442@lancre>
References: <23D017C9-81B7-484D-8490-FD94DEC4DF59@amazon.com>
 <alpine.DEB.2.20.1801240847010.2307@lancre>
 <16744C85-E44E-4354-9E3D-45A7C9BDB19B@amazon.com>
 <alpine.DEB.2.20.1801252339520.26762@lancre>
 <81936381-841A-459D-9FE5-18659680355C@amazon.com>
 <alpine.DEB.2.20.1801262348420.17596@lancre>
 <654A1247-8E1E-4E9C-937D-9119B1731FF2@amazon.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Precedence: bulk


Hello Doug,

>    I'm not sure why you do the following trick, could you explain?
>       +#undef USE_SELECT
>       +#define USE_SELECT
>
> This was due to compiler complaint about USE_SELECT being redefined.
> Have replaced that "trick" with a new #define POLL_USING_SELECT which is used elsewhere in pgbench instead.

Ok, why not.

Another option to avoid the warning and a new name could have been to 
"#ifndef X #define X #endif /* !X */"

Patch applies cleanly, compiles cleanly for both options, local & global 
"make check" ok.

Switched to "Ready".

-- 
Fabien.