Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i3aeE-0003Za-Jc for pgsql-hackers@arkaria.postgresql.org; Fri, 30 Aug 2019 06:44:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i3aeC-0005TC-2X for pgsql-hackers@arkaria.postgresql.org; Fri, 30 Aug 2019 06:44:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i3aeB-0005Ro-Na for pgsql-hackers@lists.postgresql.org; Fri, 30 Aug 2019 06:44:35 +0000 Received: from courriel.mines-paristech.fr ([77.158.173.149] helo=antispam-1.ensmp.fr) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1i3ae8-0004ni-LZ for pgsql-hackers@postgresql.org; Fri, 30 Aug 2019 06:44:34 +0000 Received: from smtp-5.mines-paristech.fr (smtp.mines-paristech.fr [77.158.173.146]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by antispam-1.ensmp.fr (antispam.mines-paristech.fr) with ESMTPS id 7940855F3D; Fri, 30 Aug 2019 08:44:29 +0200 (CEST) Received: from lancre (184.86.8.93.rev.sfr.net [93.8.86.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp-5.mines-paristech.fr (Postfix) with ESMTPSA id 12D77201C6; Fri, 30 Aug 2019 08:44:29 +0200 (CEST) Date: Fri, 30 Aug 2019 08:44:28 +0200 (CEST) From: Fabien COELHO X-X-Sender: fabien@lancre To: Peter Eisentraut cc: Ibrar Ahmed , Michael Paquier , Julien Rouhaud , Tom Lane , pgsql-hackers Subject: Re: pg_upgrade: Error out on too many command-line arguments In-Reply-To: <2a70fc23-3545-d22d-2071-a42ee18757c9@2ndquadrant.com> Message-ID: References: <12750.1566743399@sss.pgh.pa.us> <20190826044317.GC7005@paquier.xyz> <2a70fc23-3545-d22d-2071-a42ee18757c9@2ndquadrant.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1865567171-1567147469=:28828" X-CLAMAV-SCAN: ok X-VRSPAM-SCORE: -100 X-VRSPAM-STATE: legit X-VRSPAM-CAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudeifedguddtlecutefuodetggdotefrucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffujgfkfhgfgggtsehmtderredtreejnecuhfhrohhmpefhrggsihgvnhcuvefqgffnjffquceotghovghlhhhosegtrhhirdgvnhhsmhhprdhfrheqnecukfhppeelfedrkedrkeeirddukeegnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhht X-VRSPAM-EXTCAUSE: mhhouggvpehsmhhtphhouhht List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1865567171-1567147469=:28828 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT Hello Peter, >> On Sun, Aug 25, 2019 at 05:10:47PM +0200, Julien Rouhaud wrote: >> > I did some searching, and oid2name.c is also missing this. >> >> And pgbench, no? >>   >> Yes, the patch is slightly different. > > Thanks, pushed all that together. Great! Could we maintain coverage by adding a TAP test? See 1 liner attached. -- Fabien. --8323329-1865567171-1567147469=:28828 Content-Type: text/x-diff; name=pgbench-too-many-1.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=pgbench-too-many-1.patch ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdiZW5jaC90LzAwMl9wZ2JlbmNoX25v X3NlcnZlci5wbCBiL3NyYy9iaW4vcGdiZW5jaC90LzAwMl9wZ2JlbmNoX25v X3NlcnZlci5wbA0KaW5kZXggZjdmYTE4NDE4Yi4uOTEyMzEyYjdjYSAxMDA2 NDQNCi0tLSBhL3NyYy9iaW4vcGdiZW5jaC90LzAwMl9wZ2JlbmNoX25vX3Nl cnZlci5wbA0KKysrIGIvc3JjL2Jpbi9wZ2JlbmNoL3QvMDAyX3BnYmVuY2hf bm9fc2VydmVyLnBsDQpAQCAtMTU3LDYgKzE1Nyw3IEBAIG15IEBvcHRpb25z ID0gKA0KIAkJCXFye2Vycm9yIHdoaWxlIHNldHRpbmcgcmFuZG9tIHNlZWQg ZnJvbSAtLXJhbmRvbS1zZWVkIG9wdGlvbn0NCiAJCV0NCiAJXSwNCisJWwkn dG9vIG1hbnkgYXJncycsICdkYm5hbWUgZm9vJywgWyBxcnt0b28gbWFueSAu KmZpcnN0IGlzICJmb28ifSBdIF0sDQogDQogCSMgbG9nZ2luZyBzdWItb3B0 aW9ucw0KIAlbDQo= --8323329-1865567171-1567147469=:28828--