Date: Fri, 30 Aug 2019 09:14:07 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
    Ibrar Ahmed <ibrar.ahmad@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>,
    Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade: Error out on too many command-line arguments
In-Reply-To: <20190830065905.GA2354@paquier.xyz>
Message-ID: <alpine.DEB.2.21.1908300905100.28828@lancre>
References: <f2554627-04e7-383a-ef01-ab99bb6a291c@2ndquadrant.com>
 <12750.1566743399@sss.pgh.pa.us>
 <CAOBaU_a5kYkR5gV7nCwjY_ZxahzM95=XACSLwg3gd7L59K3JAA@mail.gmail.com>
 <20190826044317.GC7005@paquier.xyz>
 <CALtqXTfTqTsrG4s4rHbHFE9bMwpgX7QWsDuD-hG1yX3BcJD_8Q@mail.gmail.com>
 <2a70fc23-3545-d22d-2071-a42ee18757c9@2ndquadrant.com>
 <alpine.DEB.2.21.1908300842470.28828@lancre>
 <20190830065905.GA2354@paquier.xyz>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-735296571-1567149249=:28828"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-735296571-1567149249=:28828
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT


Bonjour Michaël,

> I don't see why not.  Perhaps this could be done for pgbench and
> oid2name as well?

This is for pgbench.

I did not found a TAP test in pg_upgrade, I do not think that it is worth 
creating one for that purpose. The "test.sh" script does not seem 
appropriate for this kind of coverage error test.

The TAP test for oid2name only includes basic checks, options and 
arguments are not even tested, and there is no infra for actual testing, 
eg starting a server… Improving that would be a much more significant 
effort that the one line I added to pgbench existing TAP test.

-- 
Fabien.
--8323329-735296571-1567149249=:28828--