Date: Fri, 30 Aug 2019 16:40:11 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
    Ibrar Ahmed <ibrar.ahmad@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
    Julien Rouhaud <rjuju123@gmail.com>,
    pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade: Error out on too many command-line arguments
In-Reply-To: <15110.1567173253@sss.pgh.pa.us>
Message-ID: <alpine.DEB.2.21.1908301622100.28828@lancre>
References: <f2554627-04e7-383a-ef01-ab99bb6a291c@2ndquadrant.com>
 <12750.1566743399@sss.pgh.pa.us>
 <CAOBaU_a5kYkR5gV7nCwjY_ZxahzM95=XACSLwg3gd7L59K3JAA@mail.gmail.com>
 <20190826044317.GC7005@paquier.xyz>
 <CALtqXTfTqTsrG4s4rHbHFE9bMwpgX7QWsDuD-hG1yX3BcJD_8Q@mail.gmail.com>
 <2a70fc23-3545-d22d-2071-a42ee18757c9@2ndquadrant.com>
 <alpine.DEB.2.21.1908300842470.28828@lancre> <15110.1567173253@sss.pgh.pa.us>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1343897371-1567176012=:28828"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1343897371-1567176012=:28828
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT


Hello Tom,

>> Could we maintain coverage by adding a TAP test? See 1 liner attached.
>
> Is this issue *really* worth expending test cycles on forevermore?

With this argument consistently applied, postgres code coverage is 
consistently weak, with 25% of the code never executed, and 15% of 
functions never called. "psql" is abysmal, "libpq" is really weak.

> Test cycles are not free, and I see zero reason to think that a
> check of this sort would ever catch any bugs.  Now, if you had a
> way to detect that somebody had forgotten the case in some new
> program, that would be interesting.

It could get broken somehow, and the test would catch it?

That would be the only command which tests this feature?

This is a TAP test, not a test run on basic "make check". The cost is not 
measurable: pgbench 533 TAP tests run in 5 wallclock seconds, and this 
added test does not change that much.

Now, if you say you are against it, then it is rejected…

-- 
Fabien.
--8323329-1343897371-1567176012=:28828--