Date: Wed, 29 Jan 2020 08:25:08 +0100 (CET)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Vik Fearing <vik.fearing@2ndquadrant.com>
cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add %x to PROMPT1 and PROMPT2
In-Reply-To: <e04078e8-ae4a-b09d-896d-5f2f5a042248@2ndquadrant.com>
Message-ID: <alpine.DEB.2.21.2001271250190.24374@pseudo>
References: <09502c40-cfe1-bb29-10f9-4b3fa7b2bbb2@2ndquadrant.com>
 <alpine.DEB.2.21.2001261946530.29788@pseudo>
 <e04078e8-ae4a-b09d-896d-5f2f5a042248@2ndquadrant.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="2056645051-868570930-1580282778=:20206"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--2056645051-868570930-1580282778=:20206
Content-Type: text/plain; format=flowed; charset=UTF-8
Content-Transfer-Encoding: 8BIT


Hello Vik,

>> Isn't there examples in the documentation which use the default prompts?
>>
>> If so, should they be updated accordingly?
>
> Good catch!
> I thought about the documentation but not the examples therein.
>
> Updated patch attached.

Ok.

Only one transaction prompt example in the whole documentation:-(
No tests is troubled by the change:-(
Sigh…

Patch applies and compiles cleanly, global and psql make check ok.

Doc build ok.

Works for me.

I'd be in favor of adding a non trivial session example in psql 
documentation at the end of the prompt stuff section, something like:

BEGIN;
CREATE TABLE
   Word(data TEXT PRIMARY KEY);
COPY Word(data) FROM STDIN;
hello
\.
SELECT 2+;
ROLLBACK;

but this is not necessary for this patch.

-- 
Fabien.
--2056645051-868570930-1580282778=:20206--