Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jAaEV-00080J-TU
	for pgsql-hackers@arkaria.postgresql.org; Sat, 07 Mar 2020 14:15:16 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jAaES-0002hZ-CU
	for pgsql-hackers@arkaria.postgresql.org; Sat, 07 Mar 2020 14:15:12 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <coelho@cri.ensmp.fr>)
	id 1jAaES-0002hS-3L
	for pgsql-hackers@lists.postgresql.org; Sat, 07 Mar 2020 14:15:12 +0000
Received: from courriel.mines-paristech.fr ([77.158.173.149]
 helo=antispam-1.ensmp.fr)
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <coelho@cri.ensmp.fr>)
	id 1jAaEI-0006gK-5W
	for pgsql-hackers@postgresql.org; Sat, 07 Mar 2020 14:15:11 +0000
Received: from smtp-5.mines-paristech.fr (smtp.mines-paristech.fr
 [77.158.173.146])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by antispam-1.ensmp.fr (antispam.mines-paristech.fr) with ESMTPS id
 8FEA6A20F8;
	Sat,  7 Mar 2020 15:14:39 +0100 (CET)
Received: from pseudo (29.237.219.88.rev.sfr.net [88.219.237.29])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp-5.mines-paristech.fr (Postfix) with ESMTPSA id 24C9820077;
	Sat,  7 Mar 2020 15:14:39 +0100 (CET)
Date: Sat, 7 Mar 2020 15:14:37 +0100 (CET)
From: Fabien COELHO <coelho@cri.ensmp.fr>
X-X-Sender: fabien@pseudo
To: Justin Pryzby <pryzby@telsasoft.com>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
    David Steele <david@pgmasters.net>, pgsql-hackers@postgresql.org,
    "Bossart, Nathan" <bossartn@amazon.com>,
    Thomas Munro <thomas.munro@gmail.com>
Subject: Re: pg_ls_tmpdir to show directories and shared filesets
In-Reply-To: <20200306233507.GN684@telsasoft.com>
Message-ID: <alpine.DEB.2.21.2003071125340.21542@pseudo>
References: <20200303200117.GI684@telsasoft.com>
 <20200303202313.GA28076@alvherre.pgsql> <20200305161838.GJ684@telsasoft.com>
 <20200306233507.GN684@telsasoft.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset=US-ASCII
X-CLAMAV-SCAN: ok
X-VRSPAM-SCORE: -100
X-VRSPAM-STATE: legit
X-VRSPAM-CAUSE: 
 gggruggvucftvghtrhhoucdtuddrgedugedruddugedgieegucetufdoteggodetrfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvufgjkfhffgggtgesthdtredttdervdenucfhrhhomhephfgrsghivghnucevqffgnffjqfcuoegtohgvlhhhohestghrihdrvghnshhmphdrfhhrqeenucfkphepkeekrddvudelrddvfeejrddvleenucfrrghrrghmpehmohguvgepshhmthhpohhuth
X-VRSPAM-EXTCAUSE: mhhouggvpehsmhhtphhouhht
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk


Hello Justin,

Some feedback about the v7 patch set.

About v7.1, seems ok.

About v7.2 & v7.3 seems ok, altought the two could be merged.

About v7.4:

The documentation sentences could probably be improved "for for", "used 
... used". Maybe:

   For the temporary directory for <parameter>tablespace</parameter>, ...
->
   For <parameter>tablespace</parameter> temporary directory, ...

   Directories are used for temporary files used by parallel
   processes, and are shown recursively.
->
   Directories holding temporary files used by parallel
   processes are shown recursively.

It seems that lists are used as FIFO structures by appending, fetching & 
deleting last, all of which are O(n). ISTM it would be better to use the 
head of the list by inserting, getting and deleting first, which are O(1).

ISTM that several instances of: "pg_ls_dir_files(..., true, false);" 
should be "pg_ls_dir_files(..., true, DIR_HIDE);".

About v7.5 looks like a doc update which should be merged with v7.4.

Alas, ISTM that there are no tests on any of these functions:-(

-- 
Fabien.