Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWCpK-0000k8-DA for pgsql-hackers@arkaria.postgresql.org; Wed, 06 May 2020 05:42:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jWCom-0005N5-N7 for pgsql-hackers@arkaria.postgresql.org; Wed, 06 May 2020 05:42:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWCom-0005My-Ef for pgsql-hackers@lists.postgresql.org; Wed, 06 May 2020 05:42:04 +0000 Received: from courriel-2.mines-paristech.fr ([77.158.173.19] helo=antispam-1.ensmp.fr) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWCof-0006bP-4J for pgsql-hackers@postgresql.org; Wed, 06 May 2020 05:42:03 +0000 Received: from smtp-5.mines-paristech.fr (smtp.mines-paristech.fr [77.158.173.146]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by antispam-1.ensmp.fr (antispam.mines-paristech.fr) with ESMTPS id C6F7D5743D; Wed, 6 May 2020 07:36:23 +0200 (CEST) Received: from pseudo (27.237.219.88.rev.sfr.net [88.219.237.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp-5.mines-paristech.fr (Postfix) with ESMTPSA id 7856720057; Wed, 6 May 2020 07:36:23 +0200 (CEST) Date: Wed, 6 May 2020 07:36:21 +0200 (CEST) From: Fabien COELHO X-X-Sender: fabien@pseudo To: Bruce Momjian cc: PostgreSQL-development Subject: Re: PG 13 release notes, first draft In-Reply-To: <20200505140055.GC21752@momjian.us> Message-ID: References: <20200505031600.GB21752@momjian.us> <20200505140055.GC21752@momjian.us> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2056645051-35464285-1588743383=:3077" X-CLAMAV-SCAN: ok X-VRSPAM-SCORE: -100 X-VRSPAM-STATE: legit X-VRSPAM-CAUSE: gggruggvucftvghtrhhoucdtuddrgeduhedrjeejgdduvddvucetufdoteggodetrfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvufgjkfhffgggtgesmhdtreertdervdenucfhrhhomhephfgrsghivghnucevqffgnffjqfcuoegtohgvlhhhohestghrihdrvghnshhmphdrfhhrqeenucggtffrrghtthgvrhhnpeehkeduhedtjeehleehtefhjeefgedvgfeltdegtedttdehtdegvedugfefleelvdenucfkphepkeekrddvudelrddvfeejrddvjeenucfrrghrrghmpehmohguvgepshhmthhpohhuth X-VRSPAM-EXTCAUSE: mhhouggvpehsmhhtphhouhht List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --2056645051-35464285-1588743383=:3077 Content-Type: text/plain; format=flowed; charset=US-ASCII Hello Bruce, >> * "DOCUMENT THE DEFAULT GENERATION METHOD" >> => The default is still to generate data client-side. > > My point is that the docs are not clear about this. Indeed. > Can you fix it? Sure. Attached patch adds an explicit sentence about it, as it was only hinted about in the default initialization command string, and removes a spurious empty paragraph found nearby. -- Fabien. --2056645051-35464285-1588743383=:3077 Content-Type: text/x-diff; name=pgbench-doc-default-g-1.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=pgbench-doc-default-g-1.patch ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvcGdiZW5jaC5zZ21sIGIv ZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNoLnNnbWwNCmluZGV4IGM5YTlmMGUw ZTUuLmVmNzVlNTMyOGMgMTAwNjQ0DQotLS0gYS9kb2Mvc3JjL3NnbWwvcmVm L3BnYmVuY2guc2dtbA0KKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNo LnNnbWwNCkBAIC0xOTgsNiArMTk4LDggQEAgcGdiZW5jaCA8b3B0aW9uYWw+ IDxyZXBsYWNlYWJsZT5vcHRpb25zPC9yZXBsYWNlYWJsZT4gPC9vcHRpb25h bD4gPHJlcGxhY2VhYmxlPmQNCiAgICAgICAgICAgIDxwYXJhPg0KICAgICAg ICAgICAgIEdlbmVyYXRlIGRhdGEgYW5kIGxvYWQgaXQgaW50byB0aGUgc3Rh bmRhcmQgdGFibGVzLA0KICAgICAgICAgICAgIHJlcGxhY2luZyBhbnkgZGF0 YSBhbHJlYWR5IHByZXNlbnQuDQorICAgICAgICAgICAgRGVmYXVsdCBpcyB0 byBnZW5lcmF0ZSBkYXRhIGNsaWVudC1zaWRlICg8bGl0ZXJhbD5nPC9saXRl cmFsPikNCisgICAgICAgICAgICBhbmQgdHJhbnNtaXQgaXQgb3ZlciB0aGUg Y29ubmVjdGlvbi4NCiAgICAgICAgICAgIDwvcGFyYT4NCiAgICAgICAgICAg IDxwYXJhPg0KICAgICAgICAgICAgIFdpdGggPGxpdGVyYWw+ZzwvbGl0ZXJh bD4gKGNsaWVudC1zaWRlIGRhdGEgZ2VuZXJhdGlvbiksDQpAQCAtMjE4LDkg KzIyMCw2IEBAIHBnYmVuY2ggPG9wdGlvbmFsPiA8cmVwbGFjZWFibGU+b3B0 aW9uczwvcmVwbGFjZWFibGU+IDwvb3B0aW9uYWw+IDxyZXBsYWNlYWJsZT5k DQogICAgICAgICAgICAgbWVzc2FnZSB3aGVuIGdlbmVyYXRpbmcgZGF0YSBp bnRvDQogICAgICAgICAgICAgPHN0cnVjdG5hbWU+cGdiZW5jaF9hY2NvdW50 czwvc3RydWN0bmFtZT4gdGFibGUuDQogICAgICAgICAgICA8L3BhcmE+DQot ICAgICAgICAgICA8cGFyYT4NCi0gICAgICAgICAgICANCi0gICAgICAgICAg IDwvcGFyYT4NCiAgICAgICAgICAgPC9saXN0aXRlbT4NCiAgICAgICAgICA8 L3Zhcmxpc3RlbnRyeT4NCiAgICAgICAgICA8dmFybGlzdGVudHJ5Pg0K --2056645051-35464285-1588743383=:3077--