Date: Thu, 7 May 2020 08:29:55 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Bruce Momjian <bruce@momjian.us>
cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PG 13 release notes, first draft
In-Reply-To: <20200506230750.GA3649@momjian.us>
Message-ID: <alpine.DEB.2.22.394.2005070807160.211403@pseudo>
References: <20200505031600.GB21752@momjian.us>
 <alpine.DEB.2.22.394.2005050710540.175044@pseudo>
 <20200505140055.GC21752@momjian.us>
 <alpine.DEB.2.22.394.2005051811320.2183756@pseudo>
 <20200506230750.GA3649@momjian.us>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="2056645051-1411841811-1588832996=:211403"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--2056645051-1411841811-1588832996=:211403
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT


Hello Bruce,

>>>> * "DOCUMENT THE DEFAULT GENERATION METHOD"
>>>>   => The default is still to generate data client-side.
>>>
>>> My point is that the docs are not clear about this.
>>
>> Indeed.
>>
>>> Can you fix it?
>>
>> Sure. Attached patch adds an explicit sentence about it, as it was only
>> hinted about in the default initialization command string, and removes a
>> spurious empty paragraph found nearby.
>
> Thanks, patch applied.

Ok.

You might remove the "DOCUMENT THE DEFAULT…" in the release note.

I'm wondering about the commit comment: "Reported-by: Fabien COELHO", 
actually you reported it, not me!

After looking again at the release notes, I do really think that 
significant documentation changes do not belong to the "Source code" 
section but should be in separate "Documentation" section, and that more 
items should be listed there, because they represent a lot of not-so-fun 
work, especially Tom's restructuration of tables, and possibly others.

About pgbench, ISTM that d37ddb745be07502814635585cbf935363c8a33d is worth 
mentionning because it is a user-visible change.

-- 
Fabien.
--2056645051-1411841811-1588832996=:211403--