Date: Tue, 22 Dec 2020 10:29:56 -0400 (AST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Maxim Orlov <m.orlov@postgrespro.ru>
cc: Pavel Borisov <pashkin.elfe@gmail.com>,
    Anastasia Lubennikova <a.lubennikova@postgrespro.ru>,
    Rahila Syed <rahilasyed90@gmail.com>,
    Michael Paquier <michael@paquier.xyz>,
    PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
    Justin Pryzby <pryzby@telsasoft.com>, Robert Haas <robertmhaas@gmail.com>,
    Amul Sul <sulamul@gmail.com>
Subject: Re: [PATCH] Automatic HASH and LIST partition creation
In-Reply-To: <8b1fce70861e2143cef9c7a69b740d61@postgrespro.ru>
Message-ID: <alpine.DEB.2.22.394.2012221025000.533489@pseudo>
References: <7fec3abb-c663-c0d2-8452-a46141be6d4a@postgrespro.ru>
 <7c4013db-a628-c8bd-ce54-064389109e0f@postgrespro.ru>
 <726c63e2-ef34-8113-f3cf-90e1646e4c2b@postgrespro.ru>
 <CALT9ZEECZacCRuSthkq5ivOysL5E--v6vr9=0CFouSjEKpbOow@mail.gmail.com>
 <74a716a3-986d-c737-6217-6a3ffd488da3@postgrespro.ru>
 <20200924032738.GA28585@paquier.xyz>
 <37f1072a-16ec-8ce8-8044-1fcec85c8ed5@postgrespro.ru>
 <CAH2L28v_fmXvDF+UzMDCObgd7nuqSU=HAJPfw7w4TMx5HGv5ig@mail.gmail.com>
 <199124d5-e710-71a6-1836-4653cd668d96@postgrespro.ru>
 <CAH2L28vRKPw+uf3Voiy6zy5QUghTPueErNTz_xgpkxEKnmfL1A@mail.gmail.com>
 <d596fdf5-7985-2a79-f76f-4f7606798642@postgrespro.ru>
 <CALT9ZEFBv05OhLMKO1Lbo_Zg9a0v+U9q9twe=t-dixfR45RmVQ@mail.gmail.com>
 <CALT9ZEHL0zgOfvx9ZrH0H4FiuVOKCRU6LcjGxB+1KRPLpAq9+w@mail.gmail.com>
 <CALT9ZEHLvWsvfOpGLy8edEVGj-GYbkp03K676njhibatkqJmHA@mail.gmail.com>
 <8b1fce70861e2143cef9c7a69b740d61@postgrespro.ru>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Precedence: bulk


> CREATE TABLE foo(a int) PARTITION BY LIST(a) CONFIGURATION (FOR VALUES IN 
> (1,2),(3,4) DEFAULT PARTITION foo_def);

I would like to disagree with this syntactic approach because it would 
very specific to each partition method. IMHO the syntax should be as 
generic as possible. I'd suggest (probably again) a keyword/value list 
which would allow to be quite adaptable without inducing any pressure on 
the parser.

-- 
Fabien.