public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fabien COELHO <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: PostgreSQL Developers <[email protected]>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: Sun, 14 Mar 2021 10:54:28 +0100 (CET)
Message-ID: <alpine.DEB.2.22.394.2103141046590.164573@pseudo> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<20200201120136.fnlbfcrybgzk75pc@development>
	<alpine.DEB.2.21.2002020906030.20752@pseudo>
	<alpine.DEB.2.22.394.2006061622300.32228@pseudo>
	<CA+hUKGJo1PYkW-oxzADaXDKoEUpoHonnSq4=1cUSNyOxc53Nmg@mail.gmail.com>
	<alpine.DEB.2.22.394.2007200747040.2368970@pseudo>
	<[email protected]>
	<[email protected]>


Hello Peter,

>> This reply was two months ago, and nothing has happened, so I have
>> marked the patch as RwF.
>
> Given the ongoing work on returning multiple result sets from stored 
> procedures[0], I went to dust off this patch.
>
> Based on the feedback, I put back the titular SHOW_ALL_RESULTS option, 
> but set the default to on.  I fixed the test failure in 
> 013_crash_restart.pl.  I also trimmed back the test changes a bit so 
> that the resulting test output changes are visible better.  (We could 
> make those stylistic changes separately in another patch.)  I'll put 
> this back into the commitfest for another look.

Thanks a lot for the fixes and pushing it forward!

My 0.02€: I tested this updated version and do not have any comment on 
this version. From my point of view it could be committed. I would not 
bother to separate the test style ajustments.

-- 
Fabien.

view thread (104+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: psql - add SHOW_ALL_RESULTS option
  In-Reply-To: <alpine.DEB.2.22.394.2103141046590.164573@pseudo>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox