Date: Tue, 6 Apr 2021 23:29:01 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
In-Reply-To: <1ec5ef49-b5c8-4129-e680-fe42f8d0670b@2ndquadrant.com>
Message-ID: <alpine.DEB.2.22.394.2104062323150.2555247@pseudo>
References: <325.1579288226@sss.pgh.pa.us>
 <ba06d046-d286-46ab-92a3-a9fdf6a6df1b@manitou-mail.org>
 <20200201120136.fnlbfcrybgzk75pc@development>
 <alpine.DEB.2.21.2002020906030.20752@pseudo>
 <alpine.DEB.2.22.394.2006061622300.32228@pseudo>
 <CA+hUKGJo1PYkW-oxzADaXDKoEUpoHonnSq4=1cUSNyOxc53Nmg@mail.gmail.com>
 <alpine.DEB.2.22.394.2007200747040.2368970@pseudo>
 <20200930062105.GE1996@paquier.xyz>
 <d5b5b051-61e4-9e45-a035-e4b291f94e3b@2ndquadrant.com>
 <alpine.DEB.2.22.394.2103141046590.164573@pseudo>
 <1ec5ef49-b5c8-4129-e680-fe42f8d0670b@2ndquadrant.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="2056645051-890406961-1617744541=:2555247"
Archived-At: 
 <https://www.postgresql.org/message-id/alpine.DEB.2.22.394.2104062323150.2555247%40pseudo>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--2056645051-890406961-1617744541=:2555247
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8BIT


Hello Peter,

>> My 0.02€: I tested this updated version and do not have any comment on this 
>> version. From my point of view it could be committed. I would not bother to 
>> separate the test style ajustments.
>
> Committed.  The last thing I fixed was the diff in the copy2.out regression 
> test.  The order of the notices with respect to the error messages was wrong. 
> I fixed that by switching back to the regular notice processor during COPY 
> handling.
>
> Btw., not sure if that was mentioned before, but a cool use of this is to 
> \watch multiple queries at once, like
>
> select current_date \; select current_time \watch

Indeed, that was one of the things I tested on the patch. I'm wondering 
whether the documentation should point this out explicitely.

Anyway Thanks for the push!

-- 
Fabien.
--2056645051-890406961-1617744541=:2555247--