Date: Thu, 15 Apr 2021 13:51:20 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
cc: Michael Paquier <michael@paquier.xyz>,
    Alvaro Herrera <alvherre@alvh.no-ip.org>,
    "Bossart,    Nathan" <bossartn@amazon.com>,
    Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
    Julien Rouhaud <rjuju123@gmail.com>,
    "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
    "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
In-Reply-To: <3738387.1618451507@sss.pgh.pa.us>
Message-ID: <alpine.DEB.2.22.394.2104151336060.191178@pseudo>
References: <69C0B369-570C-4524-8EE4-BCCACECB6BEE@amazon.com>
 <20210412193301.GA11204@alvherre.pgsql> <YHeVHH0wVcRwdogL@paquier.xyz>
 <3738387.1618451507@sss.pgh.pa.us>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Archived-At: 
 <https://www.postgresql.org/message-id/alpine.DEB.2.22.394.2104151336060.191178%40pseudo>
Precedence: bulk


Hello Tom,

>> That's a lot IMO, so my vote would be to discard this feature for now
>> and revisit it properly in the 15 dev cycle, so as resources are
>> redirected into more urgent issues (13 open items as of the moment of
>> writing this email).
>
> I don't wish to tell people which open issues they ought to work on
> ... but this patch seems like it could be quite a large can of worms,
> and I'm not detecting very much urgency about getting it fixed.
> If it's not to be reverted then some significant effort needs to be
> put into it soon.

My overly naive trust in non regression test to catch any issues has been 
largely proven wrong. Three key features do not have a single tests. Sigh.

I'll have some time to look at it over next week-end, but not before.

-- 
Fabien.