Date: Thu, 17 Jun 2021 22:53:26 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Gregory Smith <gregsmithpgsql@gmail.com>,
    PostgreSQL-development <pgsql-hackers@postgresql.org>,
    david.christensen@crunchydata.com
Subject: Re: pgbench logging broken by time logic changes
In-Reply-To: 
 <CA+hUKGKJu21ieM+w73mvMGmnaHBhYtUihLHdnCCYPQU51wnwuw@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2106172244580.2941201@pseudo>
References: 
 <CAHLJuCW_8Vpcr0=t6O_gozrg3wXXWXZXDioYJd3NhvKriqgpfQ@mail.gmail.com>
 <CA+hUKG+jhatozihmqy4=Ufd0OHwZadEd_vg-_+26hE3f4C3TgQ@mail.gmail.com>
 <alpine.DEB.2.22.394.2106170917240.2693553@pseudo>
 <CA+hUKGKJu21ieM+w73mvMGmnaHBhYtUihLHdnCCYPQU51wnwuw@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset=US-ASCII
Archived-At: 
 <https://www.postgresql.org/message-id/alpine.DEB.2.22.394.2106172244580.2941201%40pseudo>
Precedence: bulk


Hello Thomas,

> I prepared a draft revert patch for discussion, just in case it comes
> in handy.  This reverts "pgbench: Improve time logic.", but "pgbench:
> Synchronize client threads." remains (slightly rearranged).

I had a quick look.

I had forgotten that this patch also fixed the long-running brain-damaged 
tps computation that has been bothering me for years, so that one sane 
performance figure is now reported instead of two not-clear-to-interpret 
take-your-pick figures.

It would be a real loss if this user-facing fix is removed in the 
process:-(

-- 
Fabien.