Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luLtC-00052N-Cq for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Jun 2021 21:18:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1luLtB-0007B9-CX for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Jun 2021 21:18:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luLtB-0007B1-10 for pgsql-hackers@lists.postgresql.org; Fri, 18 Jun 2021 21:18:57 +0000 Received: from sfr-1.cri.mines-paristech.fr ([77.158.180.225] helo=smtp.cri.ensmp.fr) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luLt6-0001Kx-53 for pgsql-hackers@lists.postgresql.org; Fri, 18 Jun 2021 21:18:56 +0000 Received: from pseudo (185.141.6.84.rev.sfr.net [84.6.141.185]) by smtp.cri.ensmp.fr (Postfix) with ESMTPSA id B7800C017B; Fri, 18 Jun 2021 23:20:42 +0200 (CEST) Date: Fri, 18 Jun 2021 23:18:45 +0200 (CEST) From: Fabien COELHO X-X-Sender: fabien@pseudo To: Tom Lane cc: PostgreSQL Developers , Thomas Munro Subject: Re: Version reporting in pgbench In-Reply-To: <1234107.1624041603@sss.pgh.pa.us> Message-ID: References: <1226654.1624036821@sss.pgh.pa.us> <1234107.1624041603@sss.pgh.pa.us> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2056645051-281571979-1624051127=:3211875" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --2056645051-281571979-1624051127=:3211875 Content-Type: text/plain; format=flowed; charset=US-ASCII Hello Tom, >> Why not move the printVersion call right after the connection is >> created, at line 6374? > > I started with that, and one of the 001_pgbench_with_server.pl > tests fell over --- it was expecting no stdout output before a > "Perhaps you need to do initialization" failure. If you don't > mind changing that, Why would I mind? > I agree that printing immediately after the connection is made is a bit > less astonishing. Ok, so let's just update the test? Attached a proposal with the version moved. Note that if no connections are available, then you do not get the version, which may be a little bit strange. Attached v3 prints out the local version in that case. Not sure whether it is worth the effort. -- Fabien. --2056645051-281571979-1624051127=:3211875 Content-Type: text/x-diff; name=pgbench-version-banner-2.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=pgbench-version-banner-2.patch ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmMgYi9zcmMv YmluL3BnYmVuY2gvcGdiZW5jaC5jDQppbmRleCBkNzQ3OTkyNWNiLi5lNjEw NTViNmI3IDEwMDY0NA0KLS0tIGEvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2gu Yw0KKysrIGIvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYw0KQEAgLTYzLDYg KzYzLDcgQEANCiAjaW5jbHVkZSAiY29tbW9uL3VzZXJuYW1lLmgiDQogI2lu Y2x1ZGUgImZlX3V0aWxzL2NhbmNlbC5oIg0KICNpbmNsdWRlICJmZV91dGls cy9jb25kaXRpb25hbC5oIg0KKyNpbmNsdWRlICJmZV91dGlscy9zdHJpbmdf dXRpbHMuaCINCiAjaW5jbHVkZSAiZ2V0b3B0X2xvbmcuaCINCiAjaW5jbHVk ZSAibGlicHEtZmUuaCINCiAjaW5jbHVkZSAicGdiZW5jaC5oIg0KQEAgLTU0 OTMsNiArNTQ5NCwzNyBAQCBwcmludFNpbXBsZVN0YXRzKGNvbnN0IGNoYXIg KnByZWZpeCwgU2ltcGxlU3RhdHMgKnNzKQ0KIAl9DQogfQ0KIA0KKy8qIHBy aW50IHZlcnNpb24gYmFubmVyICovDQorc3RhdGljIHZvaWQNCitwcmludFZl cnNpb24oUEdjb25uICpjb24pDQorew0KKwlpbnQJCQlzZXJ2ZXJfdmVyID0g UFFzZXJ2ZXJWZXJzaW9uKGNvbik7DQorCWludAkJCWNsaWVudF92ZXIgPSBQ R19WRVJTSU9OX05VTTsNCisNCisJaWYgKHNlcnZlcl92ZXIgIT0gY2xpZW50 X3ZlcikNCisJew0KKwkJY29uc3QgY2hhciAqc2VydmVyX3ZlcnNpb247DQor CQljaGFyCQlzdmVyYnVmWzMyXTsNCisNCisJCS8qIFRyeSB0byBnZXQgZnVs bCB0ZXh0IGZvcm0sIG1pZ2h0IGluY2x1ZGUgImRldmVsIiBldGMgKi8NCisJ CXNlcnZlcl92ZXJzaW9uID0gUFFwYXJhbWV0ZXJTdGF0dXMoY29uLCAic2Vy dmVyX3ZlcnNpb24iKTsNCisJCS8qIE90aGVyd2lzZSBmYWxsIGJhY2sgb24g c2VydmVyX3ZlciAqLw0KKwkJaWYgKCFzZXJ2ZXJfdmVyc2lvbikNCisJCXsN CisJCQlmb3JtYXRQR1ZlcnNpb25OdW1iZXIoc2VydmVyX3ZlciwgdHJ1ZSwN CisJCQkJCQkJCSAgc3ZlcmJ1Ziwgc2l6ZW9mKHN2ZXJidWYpKTsNCisJCQlz ZXJ2ZXJfdmVyc2lvbiA9IHN2ZXJidWY7DQorCQl9DQorDQorCQlwcmludGYo XygiJXMgKCVzLCBzZXJ2ZXIgJXMpXG4iKSwNCisJCQkgICAicGdiZW5jaCIs IFBHX1ZFUlNJT04sIHNlcnZlcl92ZXJzaW9uKTsNCisJfQ0KKwkvKiBGb3Ig dmVyc2lvbiBtYXRjaCwgb25seSBwcmludCBwZ2JlbmNoIHZlcnNpb24gKi8N CisJZWxzZQ0KKwkJcHJpbnRmKCIlcyAoJXMpXG4iLCAicGdiZW5jaCIsIFBH X1ZFUlNJT04pOw0KKwlmZmx1c2goc3Rkb3V0KTsNCit9DQorDQogLyogcHJp bnQgb3V0IHJlc3VsdHMgKi8NCiBzdGF0aWMgdm9pZA0KIHByaW50UmVzdWx0 cyhTdGF0c0RhdGEgKnRvdGFsLA0KQEAgLTU1MDYsNyArNTUzOCw2IEBAIHBy aW50UmVzdWx0cyhTdGF0c0RhdGEgKnRvdGFsLA0KIAlkb3VibGUJCWJlbmNo X2R1cmF0aW9uID0gUEdfVElNRV9HRVRfRE9VQkxFKHRvdGFsX2R1cmF0aW9u KTsNCiAJZG91YmxlCQl0cHMgPSBudHggLyBiZW5jaF9kdXJhdGlvbjsNCiAN Ci0JcHJpbnRmKCJwZ2JlbmNoIChQb3N0Z3JlU1FMKSAlZC4lZFxuIiwgUEdf VkVSU0lPTl9OVU0gLyAxMDAwMCwgUEdfVkVSU0lPTl9OVU0gJSAxMDApOw0K IAkvKiBSZXBvcnQgdGVzdCBwYXJhbWV0ZXJzLiAqLw0KIAlwcmludGYoInRy YW5zYWN0aW9uIHR5cGU6ICVzXG4iLA0KIAkJICAgbnVtX3NjcmlwdHMgPT0g MSA/IHNxbF9zY3JpcHRbMF0uZGVzYyA6ICJtdWx0aXBsZSBzY3JpcHRzIik7 DQpAQCAtNjMzNCw2ICs2MzY1LDkgQEAgbWFpbihpbnQgYXJnYywgY2hhciAq KmFyZ3YpDQogCWlmIChjb24gPT0gTlVMTCkNCiAJCWV4aXQoMSk7DQogDQor CS8qIHJlcG9ydCBwZ2JlbmNoIGFuZCBzZXJ2ZXIgdmVyc2lvbnMgKi8NCisJ cHJpbnRWZXJzaW9uKGNvbik7DQorDQogCXBnX2xvZ19kZWJ1ZygicGdob3N0 OiAlcyBwZ3BvcnQ6ICVzIG5jbGllbnRzOiAlZCAlczogJWQgZGJOYW1lOiAl cyIsDQogCQkJCSBQUWhvc3QoY29uKSwgUFFwb3J0KGNvbiksIG5jbGllbnRz LA0KIAkJCQkgZHVyYXRpb24gPD0gMCA/ICJueGFjdHMiIDogImR1cmF0aW9u IiwNCmRpZmYgLS1naXQgYS9zcmMvYmluL3BnYmVuY2gvdC8wMDFfcGdiZW5j aF93aXRoX3NlcnZlci5wbCBiL3NyYy9iaW4vcGdiZW5jaC90LzAwMV9wZ2Jl bmNoX3dpdGhfc2VydmVyLnBsDQppbmRleCA1NWIzYzNmNmZkLi40OWZlNDgw OTNjIDEwMDY0NA0KLS0tIGEvc3JjL2Jpbi9wZ2JlbmNoL3QvMDAxX3BnYmVu Y2hfd2l0aF9zZXJ2ZXIucGwNCisrKyBiL3NyYy9iaW4vcGdiZW5jaC90LzAw MV9wZ2JlbmNoX3dpdGhfc2VydmVyLnBsDQpAQCAtMTAwLDcgKzEwMCw3IEBA IHBnYmVuY2goDQogCSdubyBzdWNoIGRhdGFiYXNlJyk7DQogDQogcGdiZW5j aCgNCi0JJy1TIC10IDEnLCAxLCBbcXJ7XiR9XSwNCisJJy1TIC10IDEnLCAx LCBbcXJ7XnBnYmVuY2ggXChbXlxuXStcKSR9XSwNCiAJW3Fye1BlcmhhcHMg eW91IG5lZWQgdG8gZG8gaW5pdGlhbGl6YXRpb259XSwNCiAJJ3J1biB3aXRo b3V0IGluaXQnKTsNCiANCg== --2056645051-281571979-1624051127=:3211875 Content-Type: text/x-diff; name=pgbench-version-banner-3.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=pgbench-version-banner-3.patch ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmMgYi9zcmMv YmluL3BnYmVuY2gvcGdiZW5jaC5jDQppbmRleCBkNzQ3OTkyNWNiLi4yMDkx MGU1YWQxIDEwMDY0NA0KLS0tIGEvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2gu Yw0KKysrIGIvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYw0KQEAgLTYzLDYg KzYzLDcgQEANCiAjaW5jbHVkZSAiY29tbW9uL3VzZXJuYW1lLmgiDQogI2lu Y2x1ZGUgImZlX3V0aWxzL2NhbmNlbC5oIg0KICNpbmNsdWRlICJmZV91dGls cy9jb25kaXRpb25hbC5oIg0KKyNpbmNsdWRlICJmZV91dGlscy9zdHJpbmdf dXRpbHMuaCINCiAjaW5jbHVkZSAiZ2V0b3B0X2xvbmcuaCINCiAjaW5jbHVk ZSAibGlicHEtZmUuaCINCiAjaW5jbHVkZSAicGdiZW5jaC5oIg0KQEAgLTU0 OTMsNiArNTQ5NCwzNyBAQCBwcmludFNpbXBsZVN0YXRzKGNvbnN0IGNoYXIg KnByZWZpeCwgU2ltcGxlU3RhdHMgKnNzKQ0KIAl9DQogfQ0KIA0KKy8qIHBy aW50IHZlcnNpb24gYmFubmVyICovDQorc3RhdGljIHZvaWQNCitwcmludFZl cnNpb24oUEdjb25uICpjb24pDQorew0KKwlpbnQJCQlzZXJ2ZXJfdmVyID0g UFFzZXJ2ZXJWZXJzaW9uKGNvbik7DQorCWludAkJCWNsaWVudF92ZXIgPSBQ R19WRVJTSU9OX05VTTsNCisNCisJaWYgKHNlcnZlcl92ZXIgIT0gY2xpZW50 X3ZlcikNCisJew0KKwkJY29uc3QgY2hhciAqc2VydmVyX3ZlcnNpb247DQor CQljaGFyCQlzdmVyYnVmWzMyXTsNCisNCisJCS8qIFRyeSB0byBnZXQgZnVs bCB0ZXh0IGZvcm0sIG1pZ2h0IGluY2x1ZGUgImRldmVsIiBldGMgKi8NCisJ CXNlcnZlcl92ZXJzaW9uID0gUFFwYXJhbWV0ZXJTdGF0dXMoY29uLCAic2Vy dmVyX3ZlcnNpb24iKTsNCisJCS8qIE90aGVyd2lzZSBmYWxsIGJhY2sgb24g c2VydmVyX3ZlciAqLw0KKwkJaWYgKCFzZXJ2ZXJfdmVyc2lvbikNCisJCXsN CisJCQlmb3JtYXRQR1ZlcnNpb25OdW1iZXIoc2VydmVyX3ZlciwgdHJ1ZSwN CisJCQkJCQkJCSAgc3ZlcmJ1Ziwgc2l6ZW9mKHN2ZXJidWYpKTsNCisJCQlz ZXJ2ZXJfdmVyc2lvbiA9IHN2ZXJidWY7DQorCQl9DQorDQorCQlwcmludGYo XygiJXMgKCVzLCBzZXJ2ZXIgJXMpXG4iKSwNCisJCQkgICAicGdiZW5jaCIs IFBHX1ZFUlNJT04sIHNlcnZlcl92ZXJzaW9uKTsNCisJfQ0KKwkvKiBGb3Ig dmVyc2lvbiBtYXRjaCwgb25seSBwcmludCBwZ2JlbmNoIHZlcnNpb24gKi8N CisJZWxzZQ0KKwkJcHJpbnRmKCIlcyAoJXMpXG4iLCAicGdiZW5jaCIsIFBH X1ZFUlNJT04pOw0KKwlmZmx1c2goc3Rkb3V0KTsNCit9DQorDQogLyogcHJp bnQgb3V0IHJlc3VsdHMgKi8NCiBzdGF0aWMgdm9pZA0KIHByaW50UmVzdWx0 cyhTdGF0c0RhdGEgKnRvdGFsLA0KQEAgLTU1MDYsNyArNTUzOCw2IEBAIHBy aW50UmVzdWx0cyhTdGF0c0RhdGEgKnRvdGFsLA0KIAlkb3VibGUJCWJlbmNo X2R1cmF0aW9uID0gUEdfVElNRV9HRVRfRE9VQkxFKHRvdGFsX2R1cmF0aW9u KTsNCiAJZG91YmxlCQl0cHMgPSBudHggLyBiZW5jaF9kdXJhdGlvbjsNCiAN Ci0JcHJpbnRmKCJwZ2JlbmNoIChQb3N0Z3JlU1FMKSAlZC4lZFxuIiwgUEdf VkVSU0lPTl9OVU0gLyAxMDAwMCwgUEdfVkVSU0lPTl9OVU0gJSAxMDApOw0K IAkvKiBSZXBvcnQgdGVzdCBwYXJhbWV0ZXJzLiAqLw0KIAlwcmludGYoInRy YW5zYWN0aW9uIHR5cGU6ICVzXG4iLA0KIAkJICAgbnVtX3NjcmlwdHMgPT0g MSA/IHNxbF9zY3JpcHRbMF0uZGVzYyA6ICJtdWx0aXBsZSBzY3JpcHRzIik7 DQpAQCAtNjMzMiw3ICs2MzYzLDEzIEBAIG1haW4oaW50IGFyZ2MsIGNoYXIg Kiphcmd2KQ0KIAkvKiBvcGVuaW5nIGNvbm5lY3Rpb24uLi4gKi8NCiAJY29u ID0gZG9Db25uZWN0KCk7DQogCWlmIChjb24gPT0gTlVMTCkNCisJew0KKwkJ cHJpbnRmKCIlcyAoJXMpXG4iLCAicGdiZW5jaCIsIFBHX1ZFUlNJT04pOw0K IAkJZXhpdCgxKTsNCisJfQ0KKw0KKwkvKiByZXBvcnQgcGdiZW5jaCBhbmQg c2VydmVyIHZlcnNpb25zICovDQorCXByaW50VmVyc2lvbihjb24pOw0KIA0K IAlwZ19sb2dfZGVidWcoInBnaG9zdDogJXMgcGdwb3J0OiAlcyBuY2xpZW50 czogJWQgJXM6ICVkIGRiTmFtZTogJXMiLA0KIAkJCQkgUFFob3N0KGNvbiks IFBRcG9ydChjb24pLCBuY2xpZW50cywNCmRpZmYgLS1naXQgYS9zcmMvYmlu L3BnYmVuY2gvdC8wMDFfcGdiZW5jaF93aXRoX3NlcnZlci5wbCBiL3NyYy9i aW4vcGdiZW5jaC90LzAwMV9wZ2JlbmNoX3dpdGhfc2VydmVyLnBsDQppbmRl eCA1NWIzYzNmNmZkLi42YTQwZTRiN2QxIDEwMDY0NA0KLS0tIGEvc3JjL2Jp bi9wZ2JlbmNoL3QvMDAxX3BnYmVuY2hfd2l0aF9zZXJ2ZXIucGwNCisrKyBi L3NyYy9iaW4vcGdiZW5jaC90LzAwMV9wZ2JlbmNoX3dpdGhfc2VydmVyLnBs DQpAQCAtOTIsNyArOTIsNyBAQCBwZ2JlbmNoKA0KIHBnYmVuY2goDQogCSdu by1zdWNoLWRhdGFiYXNlJywNCiAJMSwNCi0JW3Fye14kfV0sDQorCVtxcnte cGdiZW5jaCBcKFteXG5dKlwpJH1dLA0KIAlbDQogCQlxcntjb25uZWN0aW9u IHRvIHNlcnZlciAuKiBmYWlsZWR9LA0KIAkJcXJ7RkFUQUw6ICBkYXRhYmFz ZSAibm8tc3VjaC1kYXRhYmFzZSIgZG9lcyBub3QgZXhpc3R9DQpAQCAtMTAw LDcgKzEwMCw3IEBAIHBnYmVuY2goDQogCSdubyBzdWNoIGRhdGFiYXNlJyk7 DQogDQogcGdiZW5jaCgNCi0JJy1TIC10IDEnLCAxLCBbcXJ7XiR9XSwNCisJ Jy1TIC10IDEnLCAxLCBbcXJ7XnBnYmVuY2ggXChbXlxuXStcKSR9XSwNCiAJ W3Fye1BlcmhhcHMgeW91IG5lZWQgdG8gZG8gaW5pdGlhbGl6YXRpb259XSwN CiAJJ3J1biB3aXRob3V0IGluaXQnKTsNCiANCg== --2056645051-281571979-1624051127=:3211875--