Date: Mon, 28 Jun 2021 10:20:52 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
cc: Tom Lane <tgl@sss.pgh.pa.us>, Jacob Champion <pchampion@vmware.com>,
    "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
    Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Preventing abort() and exit() calls in libpq
In-Reply-To: <YNl/rGAtp0Ovmtis@paquier.xyz>
Message-ID: <alpine.DEB.2.22.394.2106281013430.1401908@pseudo>
References: <3128896.1624742969@sss.pgh.pa.us> <YNl/rGAtp0Ovmtis@paquier.xyz>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Archived-At: 
 <https://www.postgresql.org/message-id/alpine.DEB.2.22.394.2106281013430.1401908%40pseudo>
Precedence: bulk


>> +# Check for functions that libpq must not call.
>> +# (If nm doesn't exist or doesn't work on shlibs, this test will silently
>> +# do nothing, which is fine.)
>> +.PHONY: check-libpq-refs
>> +check-libpq-refs: $(shlib)
>> +	@! nm -A -g -u $< 2>/dev/null | grep -e abort -e exit
>
> "abort" and "exit" could be generic terms present in some other
> libraries.  Could be be better to match with "U abort" and "U exit"
> instead?  MinGW has a nm command, and it has a compatible option set,
> so I think that it should work.

A possible trick is to add ccp flags such as: -Dexit=exit_BAD 
-Dabort=abort_BAD.

-- 
Fabien.