Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6Rcw-0001Qe-IM for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Jul 2021 05:52:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Rct-0007Gj-Q2 for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Jul 2021 05:52:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6Rct-0007Gb-IF for pgsql-hackers@lists.postgresql.org; Thu, 22 Jul 2021 05:52:07 +0000 Received: from sfr-1.cri.mines-paristech.fr ([77.158.180.225] helo=smtp.cri.ensmp.fr) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6Rcq-0000k7-Mb for pgsql-hackers@lists.postgresql.org; Thu, 22 Jul 2021 05:52:06 +0000 Received: from pseudo (ip-160.net-81-220-45.lyon.rev.numericable.fr [81.220.45.160]) by smtp.cri.ensmp.fr (Postfix) with ESMTPSA id 9B6D9C00DA; Thu, 22 Jul 2021 07:54:08 +0200 (CEST) Date: Thu, 22 Jul 2021 07:52:02 +0200 (CEST) From: Fabien COELHO X-X-Sender: fabien@pseudo To: Peter Eisentraut cc: "pgsql-hackers@lists.postgresql.org" Subject: Re: psql - add SHOW_ALL_RESULTS option In-Reply-To: <18c78a01-4a34-9dd4-f78b-6860f1420c8e@enterprisedb.com> Message-ID: References: <69C0B369-570C-4524-8EE4-BCCACECB6BEE@amazon.com> <20210412193301.GA11204@alvherre.pgsql> <3738387.1618451507@sss.pgh.pa.us> <451a2111-3757-c511-9413-8f8af531a167@enterprisedb.com> <18c78a01-4a34-9dd4-f78b-6860f1420c8e@enterprisedb.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2056645051-1901542663-1626933123=:25741" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --2056645051-1901542663-1626933123=:25741 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT >>> The patch does not apply on Head anymore, could you rebase and post a >>> patch. I'm changing the status to "Waiting for Author". >> >> Ok. I noticed. The patch got significantly broken by the watch pager >> commit. I also have to enhance the added tests (per Peter request). > > I wrote a test to check psql query cancel support. I checked that it fails > against the patch that was reverted. Maybe this is useful. Thank you! The patch update is in progress… The newly added PSQL_WATCH_PAGER feature which broke the patch does not seem to be tested anywhere, this is tiring:-( -- Fabien. --2056645051-1901542663-1626933123=:25741--