Date: Thu, 22 Jul 2021 11:00:41 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Pavel Stehule <pavel.stehule@gmail.com>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
    "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
In-Reply-To: 
 <CAFj8pRD6XuTgbLCaHra+t1PJBEm8SL+y-Qmhax3-5A=0Q9xO0g@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2107221051140.25741@pseudo>
References: <69C0B369-570C-4524-8EE4-BCCACECB6BEE@amazon.com>
 <20210412193301.GA11204@alvherre.pgsql> <YHeVHH0wVcRwdogL@paquier.xyz>
 <3738387.1618451507@sss.pgh.pa.us>
 <alpine.DEB.2.22.394.2104151336060.191178@pseudo>
 <451a2111-3757-c511-9413-8f8af531a167@enterprisedb.com>
 <alpine.DEB.2.22.394.2106121130400.4105466@pseudo>
 <CALDaNm0+pzGgp-M1mAoUVYRtjadbWYuB96J8RaV9iH3+HA8FTA@mail.gmail.com>
 <alpine.DEB.2.22.394.2107151742300.1705285@pseudo>
 <18c78a01-4a34-9dd4-f78b-6860f1420c8e@enterprisedb.com>
 <alpine.DEB.2.22.394.2107220744430.25741@pseudo>
 <CAFj8pRD6XuTgbLCaHra+t1PJBEm8SL+y-Qmhax3-5A=0Q9xO0g@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="2056645051-862124652-1626944441=:25741"
Archived-At: 
 <https://www.postgresql.org/message-id/alpine.DEB.2.22.394.2107221051140.25741%40pseudo>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--2056645051-862124652-1626944441=:25741
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT


Hello Pavel,

>> The newly added PSQL_WATCH_PAGER feature which broke the patch does not
>> seem to be tested anywhere, this is tiring:-(
>
> Do you have any idea how this can be tested?

The TAP patch sent by Peter on this thread is a very good start.

> It requires some pager that doesn't use blocking reading, and you need 
> to do remote control of this pager. So it requires a really especially 
> written pager just for this purpose. It is solvable, but I am not sure 
> if it is adequate to this patch.

Not really: The point would not be to test the pager itself (that's for 
the people who develop the pager, not for psql), but just to test that the 
pager is actually started or not started by psql depending on conditions 
(eg pset pager…) and that it does *something* when started. See for 
instance the simplistic pager.pl script attached, the output of which 
could be tested. Note that PSQL_PAGER is not tested at all either. 
Basically "psql" is not tested, which is a pain when developing a non 
trivial patch.

-- 
Fabien.
--2056645051-862124652-1626944441=:25741
Content-Type: text/x-perl; name=pager.pl
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.DEB.2.22.394.2107221100410.25741@pseudo>
Content-Description: 
Content-Disposition: attachment; filename=pager.pl

IyEgL3Vzci9iaW4vcGVybCAtd24NCnByaW50ICIkLlx0JF8iOw0KZXhpdCgw
KSBpZiAkLiA9PSAzMDsNCg==

--2056645051-862124652-1626944441=:25741--