Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1m8dNa-0002Yv-I7
	for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Jul 2021 06:49:22 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1m8dNY-0004VP-CA
	for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Jul 2021 06:49:20 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <coelho@cri.ensmp.fr>)
	id 1m8dNY-0004Tu-4U
	for pgsql-hackers@lists.postgresql.org; Wed, 28 Jul 2021 06:49:20 +0000
Received: from sfr-1.cri.mines-paristech.fr ([77.158.180.225]
 helo=smtp.cri.ensmp.fr)
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <coelho@cri.ensmp.fr>)
	id 1m8dNU-0003Uq-Uv
	for pgsql-hackers@lists.postgresql.org; Wed, 28 Jul 2021 06:49:19 +0000
Received: from GB2AEDM0Q2N9HV2 (pop.92-184-106-82.mobile.abo.orange.fr
 [92.184.106.82])
	by smtp.cri.ensmp.fr (Postfix) with ESMTPSA id AA30EC0346;
	Wed, 28 Jul 2021 08:51:20 +0200 (CEST)
Date: Wed, 28 Jul 2021 08:49:12 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
X-X-Sender: fabien@pseudo
To: Michael Paquier <michael@paquier.xyz>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
    Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Some code cleanup for pgbench and pg_verifybackup
In-Reply-To: <YQDMdB+B68yePFeT@paquier.xyz>
Message-ID: <alpine.DEB.2.22.394.2107280844590.1963471@pseudo>
References: <alpine.DEB.2.22.394.2107260946550.297424@pseudo>
 <202107261935.tad2ojwemn3v@alvherre.pgsql> <YP9LEHjcSng0Yk0R@paquier.xyz>
 <YQDMdB+B68yePFeT@paquier.xyz>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset=US-ASCII
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/alpine.DEB.2.22.394.2107280844590.1963471%40pseudo>
Precedence: bulk


> [...] Thoughts?

For pgbench it is definitely ok to add the exit. For others the added 
exits look reasonable, but I do not know them intimately enough to be sure 
that it is the right thing to do in all cases.

> All that does not seem to enter into the category of things worth 
> back-patching, except for pg_verifybackup.

Yes.

-- 
Fabien.