Date: Sun, 3 Apr 2022 10:20:05 +0200 (CEST)
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, nagata@sraoss.co.jp,
    thomas.munro@gmail.com, m.polyakova@postgrespro.ru,
    pgsql-hackers@postgresql.org, teodor@sigaev.ru
Subject: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock
 errors
In-Reply-To: <20220403.152819.1855287099476193181.t-ishii@sranhm.sra.co.jp>
Message-ID: <alpine.DEB.2.22.394.2204030956500.2117840@pseudo>
References: <202203280757.3tu4ovs3petm@alvherre.pgsql>
 <701162.1648474392@sss.pgh.pa.us>
 <20220401.095700.2266633058878785752.t-ishii@sranhm.sra.co.jp>
 <20220403.152819.1855287099476193181.t-ishii@sranhm.sra.co.jp>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="2056645051-1990285720-1648974005=:2117840"
Archived-At: 
 <https://www.postgresql.org/message-id/alpine.DEB.2.22.394.2204030956500.2117840%40pseudo>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--2056645051-1990285720-1648974005=:2117840
Content-Type: text/plain; format=flowed; charset=ISO-8859-15
Content-Transfer-Encoding: 8BIT


>> Or those three columns always, sum_lag sum_lag_2, min_lag max_lag, 
>> skipped, retried retries?
>
> What about this? (a log line is not actually folded)
> interval_start num_transactions sum_latency sum_latency_2 min_latency max_latency
> failures serialization_failures deadlock_failures retried retries [ sum_lag sum_lag_2 min_lag max_lag [ skipped ] ]

My 0.02¤:

I agree that it would be better to have a more deterministic 
aggregated log format.

ISTM that it should skip failures and lags if no fancy options has been 
selected, i.e.:

   [ fails ... retries [ sum_lag ... [ skipped ] ] ?

Alterlatively, as the failure stuff is added to the format, maybe it could 
be at the end:

   [ sum_lag ... [ skipped [ fails ... retries ] ] ] ?


> failures:
> always 0 (if --max-tries is 1, the default)
> sum of serialization_failures and deadlock_failures (if --max-tries is not 1)
>
> serialization_failures and deadlock_failures:
> always 0 (if --max-tries is 1, the default)
> 0 or more (if --max-tries is not 1)
>
> retried and retries:
> always 0 (if --max-tries is 1, the default)
> 0 or more (if --max-tries is not 1)
>
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>

-- 
Fabien.
--2056645051-1990285720-1648974005=:2117840--