Feedback-ID: ie3de48e3:Fastmail
Date: Sat, 25 Jul 2026 09:07:26 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Anton Voloshin <a.voloshin@postgrespro.ru>,
	Euler Taveira <euler@eulerto.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: NULL pointer dereference in syslogger with load_libraries() and
 -DEXEC_BACKEND at startup
Message-ID: <amRgZ272UyE7i8UA@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <amQzWzZTFop7AktH@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/amRgZ272UyE7i8UA%40alvherre.pgsql>
Precedence: bulk

On 2026-Jul-25, Michael Paquier wrote:

> Confirmed.  Running another flavor, as of this command, I can see the
> same output:
> $ src/tools/mark_pgdllimport.pl $(git ls-files src/include/)
> src/include/common/logging.h: adding 1 PGDLLIMPORT markers
> src/include/postmaster/syslogger.h: adding 1 PGDLLIMPORT markers
> 
> Not touching logging.h is intentional, the new syslogger_setup_done
> should be marked with PGDLLIMPORT.  That's the only hole currently in
> the tree.

No objections from me.  In fact, since this is my fail, please let me do
it instead.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Escucha y olvidarás; ve y recordarás; haz y entenderás" (Confucio)